Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Builds with Go 1.16.6 #310

Merged
merged 1 commit into from
Jul 21, 2021
Merged

Builds with Go 1.16.6 #310

merged 1 commit into from
Jul 21, 2021

Conversation

codefromthecrypt
Copy link
Contributor

Signed-off-by: Adrian Cole <[email protected]>
@netlify
Copy link

netlify bot commented Jul 19, 2021

✔️ Deploy Preview for func-e canceled.

🔨 Explore the source changes: 6038863

🔍 Inspect the deploy log: https://app.netlify.com/sites/func-e/deploys/60f50d6b397b29000885ff12

@codefromthecrypt
Copy link
Contributor Author

hmm we have something to consider which is that the e2e looks for a coherent version. Actually the linux+windows vs darwin versions are on different schedules until envoyproxy/envoy#16830 (which seems inactive).

We may want to consider using a regex vs a strict version match here in order to avoid locking up things.. WDTY @mathetake

@codefromthecrypt
Copy link
Contributor Author

also it is tricky but "latestVersion" in https://archive.tetratelabs.io/envoy/envoy-versions.json causes this.. we may want to consider not publishing at all until os/x is done as basically it ends up latest, except darwin which introduces some skew edge cases in tests and usage

@codefromthecrypt
Copy link
Contributor Author

opened tetratelabs/archive-envoy#15 on this topic

@codefromthecrypt
Copy link
Contributor Author

tetratelabs/archive-envoy#16 works around the build outage by pinning 1.18.3

@codefromthecrypt codefromthecrypt merged commit a77cae5 into master Jul 21, 2021
@codefromthecrypt codefromthecrypt deleted the go-1.16.6 branch July 21, 2021 04:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants