Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset preferences feature with button and reset functionality and cor… #1055

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

tupaschoal
Copy link
Collaborator

Continuing on #917

@tupaschoal tupaschoal mentioned this pull request Jan 13, 2024
1 task
{
if (window.mainApi.shouldResetPreferences())
{
window.mainApi.resetPreferences();
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not seeing this function exposed in the preferences-api, where does it come from?

@@ -89,6 +89,26 @@ ipcMain.handle('GET_LANGUAGE_DATA', () =>
};
});

ipcMain.handle('SHOULD_RESET_PREFERENCES', () =>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could be implemented using the existing showDialogSync, llike workday-waiver-api.mjs exposes and workday-waiver.js uses. That way we have the code contained in renderer.

function clickItem(item)
{
$(`#${item}`)
.trigger('click')
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here and below there are some linting issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants