-
Notifications
You must be signed in to change notification settings - Fork 268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reset preferences feature with button and reset functionality and cor… #1055
base: main
Are you sure you want to change the base?
Conversation
{ | ||
if (window.mainApi.shouldResetPreferences()) | ||
{ | ||
window.mainApi.resetPreferences(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not seeing this function exposed in the preferences-api, where does it come from?
@@ -89,6 +89,26 @@ ipcMain.handle('GET_LANGUAGE_DATA', () => | |||
}; | |||
}); | |||
|
|||
ipcMain.handle('SHOULD_RESET_PREFERENCES', () => |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This could be implemented using the existing showDialogSync, llike workday-waiver-api.mjs exposes and workday-waiver.js uses. That way we have the code contained in renderer.
function clickItem(item) | ||
{ | ||
$(`#${item}`) | ||
.trigger('click') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here and below there are some linting issues
Continuing on #917