Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Checkout PR before updating changelog - fixes #732 #735

Merged
merged 2 commits into from
Oct 12, 2021
Merged

Checkout PR before updating changelog - fixes #732 #735

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
49e23e9
checkout source branch of PR before updating changelog in Changelog U…
BhumikaSaini Oct 10, 2021
32226f9
update contribution guidelines to allow edits by maintainers on PRs
BhumikaSaini Oct 10, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions .github/workflows/ChangelogUpdater.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,25 +1,31 @@
name: Changelog Updater
on:
pull_request:
types: [opened]
issue_comment:
types: [created]

jobs:
update-changelog:
runs-on: macos-latest
steps:
- uses: khan/pull-request-comment-trigger@master
- name: Check trigger
id: check
uses: khan/pull-request-comment-trigger@master
with:
trigger: '\changelog-update'
reaction: rocket
prefix_only: 'true'
env:
GITHUB_TOKEN: '${{ secrets.GITHUB_TOKEN }}'
GITHUB_TOKEN: '${{secrets.GITHUB_TOKEN}}'
- name: Clone git repo
if: steps.check.outputs.triggered == 'true'
uses: actions/checkout@v2
- name: Checkout pull request
if: steps.check.outputs.triggered == 'true'
env:
GITHUB_TOKEN: ${{secrets.GITHUB_TOKEN}}
run: hub pr checkout ${{github.event.issue.number}}
- name: Configure Git Agent
if: steps.check.outputs.triggered == 'true'
run: |
git config --global user.name 'Changelog Bot'
git config --global user.email '[email protected]'
Expand Down
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,4 +13,4 @@ For bugs, it's good to provide some step-by-step instructions to reproduce the i
### When you open a pull request

All PRs are very welcome, and we'll do our best to review them as fast as possible.
Check the [development](DEVELOPMENT.md) instructions to understand how to setup a developer's environment, build and test Time to Leave.
Check the [development](DEVELOPMENT.md) instructions to understand how to setup a developer's environment, build and test Time to Leave. Please enable `Allow edits by maintainers` when raising the PR.