-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add checks to new item input #30
Conversation
Visit the preview URL for this PR (updated for commit 1e301b2): https://tcl-68-smart-shopping-list--pr30-et-ap-check-item-emp-xryu1k3k.web.app (expires Sun, 17 Mar 2024 00:50:33 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 8cb5d089a99ba9972009993f4dd31796b0cbda84 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me, nice work this week!
Great job on utilizing regex |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moved if clause Co-authored-by: Raynaldo Sutisna <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Description
Adds checks to user input of new items to alert the user if they submitted an empty item name or submitted an item that is already on their list after normalizing case and punctuation
Related Issue
closes #10
Acceptance Criteria
apples
and the user addsapples
.apples
and the user addsaPples
orapples,
ora pples
.Type of Changes
enhancement
Updates
Before
N/A
After
3c18)
Testing Steps / QA Criteria