update deps #608

YassinEldeeb · 2024-10-24T01:28:00Z

everything has been updated to the latest versions!

Breaking change

resource is no longer an acceptable field to the SpanContext in open telemetry reporting, and there's no other new fields in its place, I think maybe the service name could be added in another way? if not, I guess we could just keep being on the older otel dependencies' versions. (cc @dotansimha)

github-actions · 2024-10-24T01:28:41Z

🚨 Rust Panic Audit: 348 Potential Panic Points Detected 🚨

Crate: ``

📊 Total Usages: 243

🎁 unwrap usages: 162
🔎 expect usages: 41
🔢 array_index usages: 32
🚨 panic usages: 8

Crate: `federation_query_planner`

📊 Total Usages: 50

🚨 panic usages: 3
🎁 unwrap usages: 29
🔢 array_index usages: 10
🔎 expect usages: 8

Crate: `conductor`

📊 Total Usages: 11

🚨 panic usages: 2
🔎 expect usages: 7
🎁 unwrap usages: 2

Crate: `common`

📊 Total Usages: 11

🔢 array_index usages: 1
🎁 unwrap usages: 10

Crate: `telemetry`

📊 Total Usages: 9

🔢 array_index usages: 5
🎁 unwrap usages: 4

Crate: `cloudflare_worker`

📊 Total Usages: 8

🎁 unwrap usages: 5
🚨 panic usages: 1
🔎 expect usages: 2

Crate: `engine`

📊 Total Usages: 7

🎁 unwrap usages: 6
🔎 expect usages: 1

Crate: `tracing`

📊 Total Usages: 6

🔎 expect usages: 1
🎁 unwrap usages: 5

Crate: `config`

📊 Total Usages: 3

🚨 panic usages: 1
🎁 unwrap usages: 2

📌 Expected Annotations

Crate: `conductor`

📊 Total Expected Usages: 2

expand details

Reason: "we need to exit the process, if the logger can't be correctly set."

Code: let _guard = tracing::subscriber::set_default(subscriber);
Location: ./bin/conductor/src/lib.rs:64

Reason: "we need to exit the process, if the provided configuration file is incorrect."

Code: panic!("Failed to initialize gateway: {:?}", e);
Location: ./bin/conductor/src/lib.rs:103

Crate: `cloudflare_worker`

📊 Total Expected Usages: 4

expand details

Reason: "it panics only if the header name is not valid, and we know it is."

Code: .unwrap()
Location: ./bin/cloudflare_worker/src/http_tracing.rs:20

Reason: "it panics only if the URL source is not valid, and it's already validated before."

Code: let url = req.url().unwrap();
Location: ./bin/cloudflare_worker/src/http_tracing.rs:23

Reason: "it only panics if we are not running in a CF context, should be safe."

Code: let cf_info = req.cf().unwrap();
Location: ./bin/cloudflare_worker/src/http_tracing.rs:27

Reason: "unwraps only in special cases where "data:text" is used."

Code: let http_host = url.host().unwrap().to_string();
Location: ./bin/cloudflare_worker/src/http_tracing.rs:36

Crate: ``

📊 Total Expected Usages: 22

expand details

Reason: "if we are unable to construct the endpoints and attach them onto the gateway's http server, we have to exit"

Code: Err(e) => panic!("failed to construct endpoint: {:?}", e),
Location: ./libs/engine/src/gateway.rs:158

Reason: "we can safely index here, it's inside a test with constant defined fixtures."

Code: ConductorGateway::execute(request, &gw.routes[0].route_data).await
Location: ./libs/engine/src/gateway.rs:190

Reason: "we're parsing a statically defined constant, we know it works ;)"

Code: .unwrap()
Location: ./libs/common/src/graphql.rs:31

Reason: "we need this"

Code: panic!("Exited process!")
Location: ./libs/napi/src/lib.rs:18

Reason: "part of development docgen CLI"

Code: .expect("Failed to serialize json schema for config file!");
Location: ./libs/config/src/generate-json-schema.rs:50

Reason: "part of development docgen CLI"

Code: .expect("Failed to write the json schema to the file system!");
Location: ./libs/config/src/generate-json-schema.rs:54

Reason: "👇"

Code: let raw_contents = read_to_string(file_path)
Location: ./libs/config/src/lib.rs:815

Reason: "👇"

Code: panic!("Failed to interpolate config file, please resolve the above errors");
Location: ./libs/config/src/lib.rs:847

Reason: "👇"

Code: parse_config_from_json(&config_string).expect("Failed to parse JSON config file")
Location: ./libs/config/src/lib.rs:854

Reason: "👇"

Code: parse_config_from_yaml(&config_string).expect("Failed to parse YAML config file")
Location: ./libs/config/src/lib.rs:858

Reason: "👇"

Code: _ => panic!("Unsupported config file extension"),
Location: ./libs/config/src/lib.rs:875

Reason: "👇"

Code: None => panic!("Config file has no extension"),
Location: ./libs/config/src/lib.rs:878

Reason: "statically defined regex pattern, we know it works ;)"

Code: .unwrap();
Location: ./libs/config/src/interpolate.rs:18

Reason: "we need to exit the process, if the logger can't be correctly set."

Code: let _guard = tracing::subscriber::set_default(subscriber);
Location: ./bin/conductor/src/lib.rs:64

Reason: "we need to exit the process, if the provided configuration file is incorrect."

Code: panic!("Failed to initialize gateway: {:?}", e);
Location: ./bin/conductor/src/lib.rs:103

Reason: "it panics only if the header name is not valid, and we know it is."

Code: .unwrap()
Location: ./bin/cloudflare_worker/src/http_tracing.rs:20

Reason: "it panics only if the URL source is not valid, and it's already validated before."

Code: let url = req.url().unwrap();
Location: ./bin/cloudflare_worker/src/http_tracing.rs:23

Reason: "it only panics if we are not running in a CF context, should be safe."

Code: let cf_info = req.cf().unwrap();
Location: ./bin/cloudflare_worker/src/http_tracing.rs:27

Reason: "unwraps only in special cases where "data:text" is used."

Code: let http_host = url.host().unwrap().to_string();
Location: ./bin/cloudflare_worker/src/http_tracing.rs:36

Reason: "if initiating an http client fails, then we have to exit."

Code: let client = wasm_polyfills::create_http_client().build().unwrap();
Location: ./plugins/jwt_auth/src/jwks_provider.rs:49

Reason: "if the provided VRL code in the config file can't compile, we have to exit."

Code: panic!("failed to compile vrl program");
Location: ./plugins/vrl/src/plugin.rs:129

Reason: "states is a non-user provided variable"

Code: .expect("can't merge states when states is an empty vector!")
Location: ./plugins/vrl/src/plugin.rs:146

Crate: `config`

📊 Total Expected Usages: 9

expand details

Reason: "part of development docgen CLI"

Code: .expect("Failed to serialize json schema for config file!");
Location: ./libs/config/src/generate-json-schema.rs:50

Reason: "part of development docgen CLI"

Code: .expect("Failed to write the json schema to the file system!");
Location: ./libs/config/src/generate-json-schema.rs:54

Reason: "👇"

Code: let raw_contents = read_to_string(file_path)
Location: ./libs/config/src/lib.rs:815

Reason: "👇"

Code: panic!("Failed to interpolate config file, please resolve the above errors");
Location: ./libs/config/src/lib.rs:847

Reason: "👇"

Code: parse_config_from_json(&config_string).expect("Failed to parse JSON config file")
Location: ./libs/config/src/lib.rs:854

Reason: "👇"

Code: parse_config_from_yaml(&config_string).expect("Failed to parse YAML config file")
Location: ./libs/config/src/lib.rs:858

Reason: "👇"

Code: _ => panic!("Unsupported config file extension"),
Location: ./libs/config/src/lib.rs:875

Reason: "👇"

Code: None => panic!("Config file has no extension"),
Location: ./libs/config/src/lib.rs:878

Reason: "statically defined regex pattern, we know it works ;)"

Code: .unwrap();
Location: ./libs/config/src/interpolate.rs:18

Crate: `engine`

📊 Total Expected Usages: 2

expand details

Reason: "if we are unable to construct the endpoints and attach them onto the gateway's http server, we have to exit"

Code: Err(e) => panic!("failed to construct endpoint: {:?}", e),
Location: ./libs/engine/src/gateway.rs:158

Reason: "we can safely index here, it's inside a test with constant defined fixtures."

Code: ConductorGateway::execute(request, &gw.routes[0].route_data).await
Location: ./libs/engine/src/gateway.rs:190

Crate: `napi`

📊 Total Expected Usages: 1

expand details

Reason: "we need this"

Code: panic!("Exited process!")
Location: ./libs/napi/src/lib.rs:18

Crate: `jwt_auth`

📊 Total Expected Usages: 1

expand details

Reason: "if initiating an http client fails, then we have to exit."

Code: let client = wasm_polyfills::create_http_client().build().unwrap();
Location: ./plugins/jwt_auth/src/jwks_provider.rs:49

Crate: `common`

📊 Total Expected Usages: 1

expand details

Reason: "we're parsing a statically defined constant, we know it works ;)"

Code: .unwrap()
Location: ./libs/common/src/graphql.rs:31

Crate: `vrl`

📊 Total Expected Usages: 2

expand details

Reason: "if the provided VRL code in the config file can't compile, we have to exit."

Code: panic!("failed to compile vrl program");
Location: ./plugins/vrl/src/plugin.rs:129

Reason: "states is a non-user provided variable"

Code: .expect("can't merge states when states is an empty vector!")
Location: ./plugins/vrl/src/plugin.rs:146

github-actions · 2024-10-24T01:49:42Z

🐋 This PR was built and pushed to the following Docker images:

Docker Bake metadata

{
"conductor": {
  "buildx.build.provenance": {
    "buildType": "https://mobyproject.org/buildkit@v1",
    "materials": [
      {
        "uri": "pkg:docker/[email protected]?platform=linux%2Famd64",
        "digest": {
          "sha256": "a92ed51e0996d8e9de041ca05ce623d2c491444df6a535a566dabd5cb8336946"
        }
      },
      {
        "uri": "pkg:docker/[email protected]?platform=linux%2Famd64",
        "digest": {
          "sha256": "83101f6985c93e1e6501b3375de188ee3d2cbb89968bcc91611591f9f447bd42"
        }
      }
    ],
    "invocation": {
      "configSource": {
        "entryPoint": "Dockerfile"
      },
      "parameters": {
        "frontend": "dockerfile.v0",
        "args": {
          "label:org.opencontainers.image.authors": "The Guild <[email protected]>",
          "label:org.opencontainers.image.description": "Conductor is a robust GraphQL Gateway.",
          "label:org.opencontainers.image.docs": "https://the-guild.dev/graphql/gateway",
          "label:org.opencontainers.image.licenses": "MIT",
          "label:org.opencontainers.image.revision": "e9e7035f317dc4214e03459165c0e30684d6261b",
          "label:org.opencontainers.image.source": "https://github.com/the-guild-org/conductor",
          "label:org.opencontainers.image.title": "Conductor",
          "label:org.opencontainers.image.url": "https://the-guild.dev/graphql/gateway",
          "label:org.opencontainers.image.vendor": "The Guild",
          "label:org.opencontainers.image.version": ""
        },
        "locals": [
          {
            "name": "context"
          },
          {
            "name": "dockerfile"
          }
        ]
      },
      "environment": {
        "platform": "linux/amd64"
      }
    }
  },
  "buildx.build.ref": "builder-b1f3a102-4ee5-498b-a665-3f10f8b6d71e/builder-b1f3a102-4ee5-498b-a665-3f10f8b6d71e0/x90108dcwuwks58by40rhgm5v",
  "containerimage.config.digest": "sha256:dd37747a89c27be66c3251a407edb301df5e5a7a9fd43c11b229057683de200c",
  "containerimage.descriptor": {
    "mediaType": "application/vnd.docker.distribution.manifest.v2+json",
    "digest": "sha256:8ce8435672b988c79929ac8315e2bed39f4fd2bea6b373d517c47998bb8a2246",
    "size": 902,
    "platform": {
      "architecture": "amd64",
      "os": "linux"
    }
  },
  "containerimage.digest": "sha256:8ce8435672b988c79929ac8315e2bed39f4fd2bea6b373d517c47998bb8a2246",
  "image.name": "ghcr.io/the-guild-org/conductor/conductor:e9e7035f317dc4214e03459165c0e30684d6261b"
}
}

github-actions · 2024-10-24T01:51:13Z

✅ Benchmark Results

     data_received..................: 13 MB   221 kB/s
     data_sent......................: 22 MB   363 kB/s
     http_req_blocked...............: min=642ns    avg=2.23µs   med=1.59µs   max=372.87µs p(95)=2.5µs    p(99)=5.33µs  
     http_req_connecting............: min=0s       avg=325ns    med=0s       max=285.35µs p(95)=0s       p(99)=0s      
     http_req_duration..............: min=311.21µs avg=403.05µs med=379.3µs  max=12.61ms  p(95)=480.3µs  p(99)=554.93µs
       { expected_response:true }...: min=311.21µs avg=403.05µs med=379.3µs  max=12.61ms  p(95)=480.3µs  p(99)=554.93µs
     ✓ { scenario:rps_1000 }........: min=311.21µs avg=403.05µs med=379.3µs  max=12.61ms  p(95)=480.3µs  p(99)=554.93µs
     http_req_failed................: 0.00%   ✓ 0           ✗ 60001
     ✓ { scenario:rps_1000 }........: 0.00%   ✓ 0           ✗ 60001
     http_req_receiving.............: min=10µs     avg=25.89µs  med=25.4µs   max=5.2ms    p(95)=33.17µs  p(99)=38.32µs 
     http_req_sending...............: min=5.78µs   avg=14.49µs  med=13.24µs  max=1.54ms   p(95)=24.25µs  p(99)=32.85µs 
     http_req_tls_handshaking.......: min=0s       avg=0s       med=0s       max=0s       p(95)=0s       p(99)=0s      
     http_req_waiting...............: min=271.38µs avg=362.66µs med=339.68µs max=12.57ms  p(95)=440.98µs p(99)=509.36µs
     http_reqs......................: 60001   1000.003904/s
     ✓ { scenario:rps_1000 }........: 60001   1000.003904/s
     iteration_duration.............: min=374.56µs avg=485.89µs med=461.59µs max=13.13ms  p(95)=565.84µs p(99)=682.03µs
     iterations.....................: 60001   1000.003904/s
     ✓ { scenario:rps_1000 }........: 60001   1000.003904/s
     valid_graphql_response.........: 100.00% ✓ 60001       ✗ 0    
     ✓ { scenario:rps_1000 }........: 100.00% ✓ 60001       ✗ 0    
     valid_http_code................: 100.00% ✓ 60001       ✗ 0    
     ✓ { scenario:rps_1000 }........: 100.00% ✓ 60001       ✗ 0    
     vus............................: 1       min=0         max=2  
     vus_max........................: 200     min=200       max=200

plugins/telemetry/src/reporter/open_telemetry.rs

bin/cloudflare_worker/Cargo.toml

dotansimha · 2024-10-30T11:49:37Z

@YassinEldeeb I'm not sure why minitrace does not have this method. I can suggest 2 options for this PR:
1 - you can try to figure out how to migrate to the new version (api is limited, shouldn't be too complicated)
2 - keep the same version for the tracing lib and i can try to fix it later

.github/workflows/ci.yaml

plugins/jwt_auth/src/plugin.rs

YassinEldeeb marked this pull request as draft October 24, 2024 01:28

YassinEldeeb marked this pull request as ready for review October 27, 2024 02:51

YassinEldeeb requested a review from dotansimha October 27, 2024 02:51

YassinEldeeb commented Oct 27, 2024

View reviewed changes

plugins/telemetry/src/reporter/open_telemetry.rs Show resolved Hide resolved

YassinEldeeb commented Oct 27, 2024

View reviewed changes

bin/cloudflare_worker/Cargo.toml Show resolved Hide resolved

update deps to latest

bfb0e2c

YassinEldeeb force-pushed the update-deps branch from 0765b19 to bfb0e2c Compare October 27, 2024 03:00

YassinEldeeb added 3 commits October 30, 2024 14:10

fix wasm

de5a42b

switch to fastrace

1ec62ee

switch to fastrace

5deafc6

EmrysMyrddin reviewed Nov 4, 2024

View reviewed changes

.github/workflows/ci.yaml Outdated Show resolved Hide resolved

EmrysMyrddin reviewed Nov 4, 2024

View reviewed changes

plugins/jwt_auth/src/plugin.rs Outdated Show resolved Hide resolved

revert deps + make unwrap safer

371461f

YassinEldeeb force-pushed the update-deps branch from 96599a1 to 371461f Compare November 6, 2024 13:59

YassinEldeeb added 3 commits November 6, 2024 14:00

chore: cargo fmt

73a6548

disable wasm

4f6c285

cleanup

04f90ec

dotansimha approved these changes Nov 6, 2024

View reviewed changes

fix otel

e9e7035

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

update deps #608

update deps #608

YassinEldeeb commented Oct 24, 2024 •

edited

Loading

github-actions bot commented Oct 24, 2024 •

edited

Loading

github-actions bot commented Oct 24, 2024 •

edited

Loading

github-actions bot commented Oct 24, 2024 •

edited

Loading

dotansimha commented Oct 30, 2024

update deps #608

Are you sure you want to change the base?

update deps #608

Conversation

YassinEldeeb commented Oct 24, 2024 • edited Loading

Breaking change

github-actions bot commented Oct 24, 2024 • edited Loading

🚨 Rust Panic Audit: 348 Potential Panic Points Detected 🚨

Crate: ``

Crate: federation_query_planner

Crate: conductor

Crate: common

Crate: telemetry

Crate: cloudflare_worker

Crate: engine

Crate: tracing

Crate: config

📌 Expected Annotations

Crate: conductor

Crate: cloudflare_worker

Crate: ``

Crate: config

Crate: engine

Crate: napi

Crate: jwt_auth

Crate: common

Crate: vrl

github-actions bot commented Oct 24, 2024 • edited Loading

github-actions bot commented Oct 24, 2024 • edited Loading

✅ Benchmark Results

dotansimha commented Oct 30, 2024

YassinEldeeb commented Oct 24, 2024 •

edited

Loading

github-actions bot commented Oct 24, 2024 •

edited

Loading

Crate: `federation_query_planner`

Crate: `conductor`

Crate: `common`

Crate: `telemetry`

Crate: `cloudflare_worker`

Crate: `engine`

Crate: `tracing`

Crate: `config`

Crate: `conductor`

Crate: `cloudflare_worker`

Crate: `config`

Crate: `engine`

Crate: `napi`

Crate: `jwt_auth`

Crate: `common`

Crate: `vrl`

github-actions bot commented Oct 24, 2024 •

edited

Loading

github-actions bot commented Oct 24, 2024 •

edited

Loading