Add get_thumbs templatetag. #37
Conversation
|
If we decide this is the way to go, I can write tests for it. In particular for prefetch things. |
| def get_thumbs(image): | ||
| def _serialize_thumb(thumb): | ||
| return { | ||
| "url": Image.get_file_for_size(image, thumb.name).url, |
There was a problem hiding this comment.
Should this be related_object.get_image_url(thumb.name),?
There was a problem hiding this comment.
Here's the source for get_image_url:
def get_image_url(self, size_name='original', tmp=False):
converted = Image.get_file_for_size(self.image, size_name, tmp=tmp)
return getattr(converted, 'url', None) or u''It's doing the same thing as you are, but with a getattr that falls back to empty string. (I don't know if that would ever make a real world difference, but it's one less thing to blow up.) ISTM it's cleaner to use the method that gives you the url you want instead of doing it yourself and maybe having differences in how your code is implemented.
There was a problem hiding this comment.
Serious bikeshedding for working code that uses a public API.
|
I'm fine with this (and want One True Image Tag in the end). The only caveat is that some crop sizes have dashes in them and can't appear in the template. We'll want to migrate these to underscores, which is a good idea anyway. (I will now await the obligatory snarky Jinja comment.) |
|
I think this is the type of API that we want to move toward eventually but I'm not entirely convinced the future is in the templatetag. @joshmaker envisions a day where the API is something like |
|
Agreed, if that's possible. It'd be nice to use the API the same way in views and templates, for setting the og:image, etc. |
|
@ctbarna has this been abandoned in favor of putting the templatetag elsewhere? Or are we still planning to revisit this approach? |
No description provided.