add proxy plugin workflow

[evgeni]

needs: ekohl/ruby-version#1

[ekohl]

I'm wondering if this makes sense at all. Unlike Foreman plugins, Smart Proxy plugins are plain gems that can be installed (by depending on smart_proxy in Gemfile). So you can just use our existing gem-test workflow. It respects required_ruby_version in the gemspec and tests on all of them.

You can argue that we somehow want to enforce that it includes all the Ruby versions we care about, but is this the way to go?

[evgeni]

Well, I like opinionated solutions.
Forcing the matrix to match the one from the main proxy repo is nice.
Also allowing testing with different proxy versions (even if that's not implemented today, we could do it similarly how we test different puppets by looking at ENV[PUPPET_VERSION])

[ekohl]

Do we want to add a "Test suite" check at the end that we can mark as a required check?

[evgeni]

Do we want to add a "Test suite" check at the end that we can mark as a required check?

There already is

actions/.github/workflows/test-gem.yml

Lines 59 to 60 in 0ba3a0f

	# A dummy job that you can mark as a required check instead of each individual test
	test-suite:

Can't this be used as the "required" one?

[ekohl]

Oh yes, I suppose so.

Can we create a workflow somewhere to test this out? Perhaps in this repo itself, providing CI for CI?

[evgeni]

Way ahead of you ;)

• add GHA based CI smart_proxy_pulp#36
• use shared action Katello/smart_proxy_container_gateway#41

[evgeni]

For "in this repo" we'd need to teach test-gem to check out arbitrary repos -- should we?

[ekohl]

For "in this repo" we'd need to teach test-gem to check out arbitrary repos -- should we?

I wouldn't mind. I suppose an alternative is to introduce some dummy gemspec, but not sure if that's any better.

[evgeni]

@ekohl implemented self-testing :)

[evgeni]

The [TMP] commits gotta be dropped before merging :)

[ekohl]

Overall ACK but needs an update now that the required PRs have been merged.

[evgeni]

@ekohl this still contains two TMP commits that need dropping before merging, tests are green right now. If you ack, I'll drop the two and merge?