Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #37789 - Add snapshot tests for global_registration.erb #10315

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

goarsna
Copy link
Contributor

@goarsna goarsna commented Sep 5, 2024

In the course of #9808 @sbernhard and I were talking about adding snapshot tests for the Global Registration template.

As adding sensible and reasonable tests for the Global Registration template with various variables set is not as easy as hoped in the beginning and to not block the original PR unnecessarily, I created this PR for adding snapshot tests for the Global Registration template.

@goarsna goarsna marked this pull request as draft September 5, 2024 10:11
@nadjaheitmann
Copy link
Contributor

I think that this is a good start. As you said, it would be nice to add more parameters to test against. However, those parameters come in from the API call, so not sure how to set them in the context of template generation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants