Fixes #37009 - Implement EFI for libvirt

[ekohl]

By default this derives the firmware type from the PXE loader, just like VMware does.

It does not yet implement secure boot.

Depends on fog/fog-libvirt#134 to be released.

Currently only tested via the API, not the UI.

[ekohl]

@stejskalleos @nofaralfasi could you have a look at this and fog/fog-libvirt#134?

[nofaralfasi]

Shouldn't it be:

Suggested change

	<%= field(f, :firmware, :disabled => !new_vm, :label => _('Firmware'), :label_size => "col-md-2") do
	compute_resource.firmware_types.collect do |type, name|
	radio_button_f f, :firmware, {:disabled => !new_vm, :value => type, :text => _(name)}
	<%= field(f, :os_firmware, :disabled => !new_vm, :label => _('Firmware'), :label_size => "col-md-2") do
	compute_resource.firmware_types.collect do |type, name|
	radio_button_f f, :os_firmware, {:disabled => !new_vm, :value => type, :text => _(name)}

[ekohl]

No, the controller accepts firmware (just like the VMware side). The libvirt model then converts the option to what fog-libvirt accepts.

[nofaralfasi]

Why do we need to consider VMware here? I don't see the necessity for VMware and Libvirt forms to have the same naming convention.
If we keep it as it is, we encounter the following error: Failure: undefined method firmware for <Fog::Libvirt::Compute::Server ...

[nofaralfasi]

The checkbox only works when creating the VM. Once the VM is created, the checkbox remains unchecked.
I'm using OVMF, so I couldn't test the entire workflow.

[ekohl]

The checkbox only works when creating the VM. Once the VM is created, the checkbox remains unchecked.

This is a good point. I'm not sure if we actually support changing it, so perhaps we should hide the element on edit.

During the review we also noticed that the VMware compute resource card shows the firmware type, which this should also implement.