Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Fix "SCAP Content" menu entry #420

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

quba42
Copy link

@quba42 quba42 commented Oct 17, 2019

  • Converts the "SCAP Content" menu entry to title case.
  • Converts the uncountable noun "Content" to singular.

Relates to: https://projects.theforeman.org/issues/25223

* Converts the "SCAP Content" menu entry to title case.
* Converts the uncountable noun "Content" to singular.
@theforeman-bot
Copy link
Member

Can one of the admins verify this patch?

@quba42
Copy link
Author

quba42 commented Oct 17, 2019

The reason it is "WIP" is that converting the term "Content" to singular means that certain paths and variables should also be changed. This is more involved and needs more testing, that I have not yet gotten around to...

@ares
Copy link
Member

ares commented Oct 18, 2019

Thanks for the patch, while we're on topic, what do you think about extracting the whole menu to first level category?

@quba42
Copy link
Author

quba42 commented Oct 18, 2019

Does "first level category" mean that Open SCAP would have its own menu next to "Monitor", "Content", "Hosts", "Configure", etc. ?
If so, I don't have any particularly strong opinions on that.
I do feel like the menu path Hosts > Compliance > Reports, would fit more naturally under Monitor > Reports > Compliance.
On the other hand, I am hesitant to spread out the Open SCAP plugin's menu entries all over the UI.
Perhaps there needs to be a general discussion whether plugins should keep their menu entries together or whether they should be spread around by topic.
(As another example, I hate the fact that Katello "Content Hosts" are in the "Hosts" menu and not in the "Content" menu, imho it makes for a really awkward workflow.)

@quba42
Copy link
Author

quba42 commented Oct 18, 2019

Perhaps we should really open a discussion on discourse. I feel like my previous comment goes beyond the scope of a PR. 😄

@adamruzicka
Copy link
Contributor

Perhaps we should really open a discussion on discourse. I feel like my previous comment goes beyond the scope of a PR. 😄

@quba42 Hi, sorry for doing a bit of a repo archeology and poking into old things, but was there such a discussion?

@quba42
Copy link
Author

quba42 commented Mar 12, 2024

@adamruzicka If I did not link such a discussion here, then no, it probably did not happen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants