Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #37755 - drop oval code leftovers in React #579

Merged
merged 1 commit into from
Oct 14, 2024

Conversation

MariaAga
Copy link
Member

This code is not used anywhere in the repo anymore

@ofedoren
Copy link
Member

Thanks, @MariaAga, I'm afraid there are more things to drop. Should we drop everything that's not used or we're dropping only "broken/bothering" parts?

@MariaAga
Copy link
Member Author

I found this while updating to pf5, and these were an effort to update, so deleting them looks easier.
I didn't see anything else thats unused, but I only checked a few things

Copy link
Contributor

@adamruzicka adamruzicka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some dropped parts are still better than no dropped parts, let's get this in

@adamruzicka adamruzicka merged commit b6c60d6 into theforeman:master Oct 14, 2024
26 checks passed
@adamruzicka
Copy link
Contributor

Thank you @MariaAga !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants