Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #37753 - Update to Patternfly 5 #580

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion webpack/components/ConfirmModal.scss
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
.pf-c-backdrop {
.pf-v5-c-backdrop {
z-index: 1040;
}
166 changes: 0 additions & 166 deletions webpack/components/EditableInput.js

This file was deleted.

3 changes: 0 additions & 3 deletions webpack/components/EditableInput.scss

This file was deleted.

2 changes: 1 addition & 1 deletion webpack/components/EmptyState.js
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ const EmptyState = ({
ouiaEmptyStateTitleId,
}) => (
<Bullseye>
<PfEmptyState variant={EmptyStateVariant.small}>
<PfEmptyState variant={EmptyStateVariant.sm}>
<EmptyStateIcon error={!!error} search={search} lock={lock} />
<Title ouiaId={ouiaEmptyStateTitleId} headingLevel="h2" size="lg">
{title}
Expand Down
4 changes: 3 additions & 1 deletion webpack/components/HostExtentions/HostKebabItems.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
import React from 'react';
import { useSelector } from 'react-redux';
import { DropdownItem } from '@patternfly/react-core';
import {

Check failure on line 3 in webpack/components/HostExtentions/HostKebabItems.js

View workflow job for this annotation

GitHub Actions / lint_custom (14)

Replace `⏎↹DropdownItem⏎` with `·DropdownItem·`

Check failure on line 3 in webpack/components/HostExtentions/HostKebabItems.js

View workflow job for this annotation

GitHub Actions / JavaScript / Foreman develop Ruby 2.7 and Node 14

Replace `⏎↹DropdownItem⏎` with `·DropdownItem·`

Check failure on line 3 in webpack/components/HostExtentions/HostKebabItems.js

View workflow job for this annotation

GitHub Actions / JavaScript / Foreman develop Ruby 2.7 and Node 18

Replace `⏎↹DropdownItem⏎` with `·DropdownItem·`
DropdownItem
} from '@patternfly/react-core/deprecated';
import { SecurityIcon } from '@patternfly/react-icons';
import { selectAPIResponse } from 'foremanReact/redux/API/APISelectors';
import { useAPI } from 'foremanReact/common/hooks/API/APIHooks';
Expand Down
6 changes: 5 additions & 1 deletion webpack/components/IndexTable/index.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,10 @@
import React from 'react';
import PropTypes from 'prop-types';
import { Table, TableHeader, TableBody } from '@patternfly/react-table';
import {
Table,

Check failure on line 4 in webpack/components/IndexTable/index.js

View workflow job for this annotation

GitHub Actions / lint_custom (14)

Replace `↹` with `··`

Check failure on line 4 in webpack/components/IndexTable/index.js

View workflow job for this annotation

GitHub Actions / JavaScript / Foreman develop Ruby 2.7 and Node 14

Replace `↹` with `··`

Check failure on line 4 in webpack/components/IndexTable/index.js

View workflow job for this annotation

GitHub Actions / JavaScript / Foreman develop Ruby 2.7 and Node 18

Replace `↹` with `··`
TableHeader,

Check failure on line 5 in webpack/components/IndexTable/index.js

View workflow job for this annotation

GitHub Actions / lint_custom (14)

Replace `↹` with `··`

Check failure on line 5 in webpack/components/IndexTable/index.js

View workflow job for this annotation

GitHub Actions / JavaScript / Foreman develop Ruby 2.7 and Node 14

Replace `↹` with `··`

Check failure on line 5 in webpack/components/IndexTable/index.js

View workflow job for this annotation

GitHub Actions / JavaScript / Foreman develop Ruby 2.7 and Node 18

Replace `↹` with `··`
TableBody

Check failure on line 6 in webpack/components/IndexTable/index.js

View workflow job for this annotation

GitHub Actions / lint_custom (14)

Replace `↹TableBody` with `··TableBody,`

Check failure on line 6 in webpack/components/IndexTable/index.js

View workflow job for this annotation

GitHub Actions / JavaScript / Foreman develop Ruby 2.7 and Node 14

Replace `↹TableBody` with `··TableBody,`

Check failure on line 6 in webpack/components/IndexTable/index.js

View workflow job for this annotation

GitHub Actions / JavaScript / Foreman develop Ruby 2.7 and Node 18

Replace `↹TableBody` with `··TableBody,`
} from '@patternfly/react-table/deprecated';
import { Flex, FlexItem } from '@patternfly/react-core';
import Pagination from 'foremanReact/components/Pagination';
import { refreshPage } from './IndexTableHelper';
Expand Down
8 changes: 5 additions & 3 deletions webpack/components/OpenscapRemediationWizard/Footer.js
Original file line number Diff line number Diff line change
@@ -1,9 +1,11 @@
import React from 'react';
import {

Check failure on line 2 in webpack/components/OpenscapRemediationWizard/Footer.js

View workflow job for this annotation

GitHub Actions / lint_custom (14)

Replace `⏎↹Button⏎` with `·Button·`

Check failure on line 2 in webpack/components/OpenscapRemediationWizard/Footer.js

View workflow job for this annotation

GitHub Actions / JavaScript / Foreman develop Ruby 2.7 and Node 14

Replace `⏎↹Button⏎` with `·Button·`

Check failure on line 2 in webpack/components/OpenscapRemediationWizard/Footer.js

View workflow job for this annotation

GitHub Actions / JavaScript / Foreman develop Ruby 2.7 and Node 18

Replace `⏎↹Button⏎` with `·Button·`
Button,
WizardFooter,
WizardContextConsumer,
Button
} from '@patternfly/react-core';
import {
WizardFooter,

Check failure on line 6 in webpack/components/OpenscapRemediationWizard/Footer.js

View workflow job for this annotation

GitHub Actions / lint_custom (14)

Replace `↹` with `··`

Check failure on line 6 in webpack/components/OpenscapRemediationWizard/Footer.js

View workflow job for this annotation

GitHub Actions / JavaScript / Foreman develop Ruby 2.7 and Node 14

Replace `↹` with `··`

Check failure on line 6 in webpack/components/OpenscapRemediationWizard/Footer.js

View workflow job for this annotation

GitHub Actions / JavaScript / Foreman develop Ruby 2.7 and Node 18

Replace `↹` with `··`
WizardContextConsumer

Check failure on line 7 in webpack/components/OpenscapRemediationWizard/Footer.js

View workflow job for this annotation

GitHub Actions / lint_custom (14)

Replace `↹WizardContextConsumer` with `··WizardContextConsumer,`

Check failure on line 7 in webpack/components/OpenscapRemediationWizard/Footer.js

View workflow job for this annotation

GitHub Actions / JavaScript / Foreman develop Ruby 2.7 and Node 14

Replace `↹WizardContextConsumer` with `··WizardContextConsumer,`

Check failure on line 7 in webpack/components/OpenscapRemediationWizard/Footer.js

View workflow job for this annotation

GitHub Actions / JavaScript / Foreman develop Ruby 2.7 and Node 18

Replace `↹WizardContextConsumer` with `··WizardContextConsumer,`
} from '@patternfly/react-core/deprecated';
import { translate as __ } from 'foremanReact/common/I18n';
import { WIZARD_TITLES } from './constants';

Expand Down
7 changes: 6 additions & 1 deletion webpack/components/OpenscapRemediationWizard/index.js
Original file line number Diff line number Diff line change
@@ -1,7 +1,12 @@
import React, { useState, useRef } from 'react';
import { useDispatch, useSelector } from 'react-redux';
import PropTypes from 'prop-types';
import { Button, Wizard } from '@patternfly/react-core';
import {

Check failure on line 4 in webpack/components/OpenscapRemediationWizard/index.js

View workflow job for this annotation

GitHub Actions / lint_custom (14)

Replace `⏎↹Button⏎` with `·Button·`

Check failure on line 4 in webpack/components/OpenscapRemediationWizard/index.js

View workflow job for this annotation

GitHub Actions / JavaScript / Foreman develop Ruby 2.7 and Node 14

Replace `⏎↹Button⏎` with `·Button·`

Check failure on line 4 in webpack/components/OpenscapRemediationWizard/index.js

View workflow job for this annotation

GitHub Actions / JavaScript / Foreman develop Ruby 2.7 and Node 18

Replace `⏎↹Button⏎` with `·Button·`
Button
} from '@patternfly/react-core';
import {

Check failure on line 7 in webpack/components/OpenscapRemediationWizard/index.js

View workflow job for this annotation

GitHub Actions / lint_custom (14)

Replace `⏎↹Wizard⏎` with `·Wizard·`

Check failure on line 7 in webpack/components/OpenscapRemediationWizard/index.js

View workflow job for this annotation

GitHub Actions / JavaScript / Foreman develop Ruby 2.7 and Node 14

Replace `⏎↹Wizard⏎` with `·Wizard·`

Check failure on line 7 in webpack/components/OpenscapRemediationWizard/index.js

View workflow job for this annotation

GitHub Actions / JavaScript / Foreman develop Ruby 2.7 and Node 18

Replace `⏎↹Wizard⏎` with `·Wizard·`
Wizard
} from '@patternfly/react-core/deprecated';

import { sprintf, translate as __ } from 'foremanReact/common/I18n';
import { API_OPERATIONS, get } from 'foremanReact/redux/API';
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@
selectAllMode,
};
}
}, [selectedCount, fetchBulkParams, setHostIdsParam]);

Check warning on line 112 in webpack/components/OpenscapRemediationWizard/steps/ReviewHosts.js

View workflow job for this annotation

GitHub Actions / lint_custom (14)

React Hook useEffect has missing dependencies: 'exclusionSet', 'inclusionSet', 'savedHostSelectionsRef', and 'selectAllMode'. Either include them or remove the dependency array

Check warning on line 112 in webpack/components/OpenscapRemediationWizard/steps/ReviewHosts.js

View workflow job for this annotation

GitHub Actions / JavaScript / Foreman develop Ruby 2.7 and Node 14

React Hook useEffect has missing dependencies: 'exclusionSet', 'inclusionSet', 'savedHostSelectionsRef', and 'selectAllMode'. Either include them or remove the dependency array

Check warning on line 112 in webpack/components/OpenscapRemediationWizard/steps/ReviewHosts.js

View workflow job for this annotation

GitHub Actions / JavaScript / Foreman develop Ruby 2.7 and Node 18

React Hook useEffect has missing dependencies: 'exclusionSet', 'inclusionSet', 'savedHostSelectionsRef', and 'selectAllMode'. Either include them or remove the dependency array

const selectionToolbar = (
<ToolbarItem key="selectAll">
Expand Down Expand Up @@ -152,7 +152,7 @@
if (!isSelecting) setIsAllHostsSelected(false);
},
isSelected: rowData.id === hostId || isSelected(rowData.id),
disable: rowData.id === hostId || false,
isDisabled: rowData.id === hostId || false,
}}
/>
);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,7 @@ const ReviewRemediation = () => {
label={__('Reboot the system(s)')}
name="reboot-checkbox"
isChecked={isRebootSelected}
onChange={selected => setIsRebootSelected(selected)}
onChange={(_event, selected) => setIsRebootSelected(selected)}
/>
</GridItem>
)}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ const SnippetSelect = () => {
ouiaId="snippet-select"
isRequired
value={snippet}
onChange={value => setSnippet(value)}
onChange={(_event, value) => setSnippet(value)}
aria-label="FormSelect Input"
>
<FormSelectOption
Expand Down
114 changes: 0 additions & 114 deletions webpack/helpers/formFieldsHelper.js

This file was deleted.

Loading