Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quest log of letter, orum and fur quest. #339

Open
wants to merge 19 commits into
base: master
Choose a base branch
from

Conversation

omattornot
Copy link
Contributor

Hello,
I add letter_quest in quests/argeas/ (https://www.themanaworld.org/index.php/Letter_Quest.
add orum_quest quests/argeas/ (https://www.themanaworld.org/index.php/Orum_Quest.
update quests/argeas/_include with letter_quest and orum_quest.

add fur_quest in quests/kaizei/ (https://www.themanaworld.org/index.php/Agostine_The_Tailor & https://www.themanaworld.org/index.php/Lora_Tay_The_Legendary_Seamstress & https://www.themanaworld.org/index.php/Agostine's_Dream_Dress).
update quests/kaizei/_include with fur_quest.

@wushin
Copy link
Member

wushin commented May 17, 2016

@omattornot indent in client xml files is only 2 spaces. running make check will report the travis errors.

@wushin wushin added the test label May 17, 2016
@omattornot
Copy link
Contributor Author

I fix the body of quest-log in last commit.

@wushin
Copy link
Member

wushin commented May 17, 2016

Now make a Post on the forums Describing what you added/changed and what needs to be tested. Make the post under https://forums.themanaworld.org/viewforum.php?f=2

After you made that post them use the forums to private message the testers group on the forum with information about the thread you created.

</its:rules>
<var id="26">
<effect map="009-2.tmx" npc="182" value="1" effect="45"/>
<effect map="009-2.tmx" npc="182" value="2,6" effect="46"/>
Copy link
Member

@Helianthella Helianthella May 20, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

quests that are done should not display any effect on the npc, so here you should not have state 6

here I'd say
45 = 0,5
46 = 1,2,3,4

@wushin wushin added this to the v2016.6.6 milestone May 31, 2016
@Helianthella Helianthella removed the test label Nov 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants