Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat]add color mix effect to the dotCursor #76

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

chase-si
Copy link

Hi,Tholman.

I used your code in my project, and added some codes to make the dot background is changeable.

I think someone else may also need the effect.
So submit a PR to you.

Here's the screenshot:
image

@tholman
Copy link
Owner

tholman commented May 29, 2024

Nice stuff!

I think a slightly more succinct way to do this would be to expose a variable called mixBlendMode as a string, that takes the option of "difference" (or any of the others, if someone may find they want them).

I almost think we make 'difference' the default, looks way nicer.

@chase-si
Copy link
Author

Nice stuff!

I think a slightly more succinct way to do this would be to expose a variable called mixBlendMode as a string, that takes the option of "difference" (or any of the others, if someone may find they want them).

I almost think we make 'difference' the default, looks way nicer.

Hi, I have added a new commit to change mixDotBgColor to mixBlendMode.

But I didn't set thedifference as the default value.

It may make a small change for the guys that using your npm package to build their page, when they update the version.

For example, if I set it as default value, in your example(Following Dot), the gray dot will be lighter because it will mix with the white background.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants