Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix shoulda-matchers typo in guide and test #1225

Merged
merged 2 commits into from
Sep 23, 2024
Merged

Fix shoulda-matchers typo in guide and test #1225

merged 2 commits into from
Sep 23, 2024

Conversation

laicuRoot
Copy link
Contributor

While checking our guides, I've noticed that there are some typos in the Shoulda Matcher name.

stevepolitodesign
stevepolitodesign reviewed Sep 21, 2024
View reviewed changes
Copy link
Contributor

@stevepolitodesign stevepolitodesign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I shoulda paid more attention when I authored these!

We'll also want to update the following:

suspenders/FEATURES.md

Line 89 in 77aff6a

spec/support/should_matchers.rb

suspenders/lib/generators/suspenders/testing_generator.rb

Line 18 in 77aff6a

spec/support/should_matchers.rb

Fortunately, the file name is correct.

@laicuRoot laicuRoot self-assigned this Sep 23, 2024
@laicuRoot laicuRoot merged commit 1fdbb22 into main Sep 23, 2024
2 checks passed
@laicuRoot laicuRoot deleted the fix-shoulda-typos branch September 23, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevepolitodesign stevepolitodesign stevepolitodesign approved these changes

Assignees

@laicuRoot laicuRoot

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@laicuRoot @stevepolitodesign