Replace isNew
with generic, filterable context
#278
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tl;dr
After this change, instead of having a fixed
isNew
, the technology radar would contain a filterable context field. This would be a breaking changeRationale
For our usage of the technology radar,
isNew
doesn't provide that much value, as the new items we can get from the git history for the csv file. As we have a lot of blips, though, we needed a way of clustering and filtering themSolution
By replacing
isNew
withcontext
, we can use more values, or oeven keep the isNew functionality. I did decide on no longer supportingisNew
, as I felt this would add complexity for downwards compatibility which wouldn't make a lot of sense in the long run. If you feel that compatibility is important let me know, and I'll add a commit that triggers the old functionality in case isNew is in the header, still.The context values are read, and will create colored blips for up to 4 different contexts. Additionally, it will create a filter element in the header, which will highlight the respective blips.
See an example here:
Benefits
isNew
, will allow filtering on the radar, thus improving usabilityTrade-Offs
context
is not really a good nameSuper interested to hear your thoughts on this change