Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DX: manage certificates with Makefile (take 2) #9

Merged
merged 7 commits into from
Aug 2, 2023
Merged

Conversation

kaihendry
Copy link
Contributor

  • refactor: fetch token programmatically
  • refactor: generate all certificates via a makefile and remove .gitignore so we can see them
  • refactor: pre-commit hooks and apply comments on DX: manage certificates with Makefile #8
  • ci: install deps for pre-commit to run

Copy link
Collaborator

@subnova subnova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@subnova subnova merged commit 2de64f5 into main Aug 2, 2023
2 checks passed
@subnova subnova deleted the autotoken2 branch August 2, 2023 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants