feat: improve Thunder's menu GQLS for better accessibility and SEO #702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat(thunder_paragraphs): add src field to ParagraphVideo type feat(thunder_gqls): add MediaSourceField data producer plugin for GraphQL feat(thunder_gqls): add ThunderMediaProvider data producer plugin fix(thunder_gqls): fix MediaVideo src field resolver to use media_source_field data producer plugin feat(thunder_gqls): add src field resolver for ParagraphVideo GraphQL type test(thunder_gqls): update paragraphs.query.graphql and paragraphs.response.json to include src field for ParagraphVideo type * Fix * Fix * Rename src to reference --------- Co-authored-by: Christian Fritsch <[email protected]>
* Allow multiple media types in entity browser view * Add update hook * Fix cs * Better description --------- Co-authored-by: Christian Fritsch <[email protected]>
* feat(composer.json): add drupal/xymatic dependency feat(thunder_xymatic): add core.entity_form_display.media.xymatic.bulk_edit.yml configuration file feat(thunder_xymatic): add default entity form display for media bundle xymatic feat(thunder_xymatic): add media form display and field for xymatic bundle feat(thunder_xymatic): add media type and field storage for Xymatic integration * Add install hook * Fix cs * Rm --------- Co-authored-by: Christian Fritsch <[email protected]>
* Release 6.5.4 * Fix * Add news article --------- Co-authored-by: Christian Fritsch <[email protected]>
dbosen
requested changes
Apr 19, 2023
…displays for media.xymatic bundle (#704) feat(thunder_xymatic): add media.xymatic.thumbnail view display configuration file Co-authored-by: Christian Fritsch <[email protected]>
* Add caption and description to xymatic * Remove caption --------- Co-authored-by: Christian Fritsch <[email protected]>
* Add video and xymatic type * Move from entity to metaData * Update thunder_paragraphs.base.graphqls --------- Co-authored-by: Christian Fritsch <[email protected]>
* Test the testing * try using selenium url without env vars * escape args * debug * more args * use localhost * add back env * add back env * no para * set env vars * no env * escape * show env * trigger * fix args * show env * move * hardcore chromedriver url * Set vars * remove escape * hardcore again * remove filter * Update tests.yml * Back to normal --------- Co-authored-by: Christian Fritsch <[email protected]> Co-authored-by: Volker Killesreiter <[email protected]>
Remove patch and unpin media_entity_pinterest.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To improve accessibility and SEO of menus in Thunder GQLS related projects it would be good to add following elements from Drupal core to Thunder's menu GQLS schema for each menu item.
Discussion with community
Attributes are not included, because here some general key/value Attribute type should be added to Thunder's GQLS and maybe GraphQL's data producer for menu_link_attribute should be checked, if this could not also provide an array of attributes instead of using it per attribute.
These attributes could be useful for other contrib modules like menu_link_attributes to get its data via GraphQL query.
What is missing
Make sure these boxes are checked before submitting your pull request - thank you!
If you are really awesome, then your feature is covered by additional tests. Well done!