Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactoring of TigerRAG
Originally meant to do enhancement of issue 5 (#5), hence the branch name. However, turned out to be a refactoring (sorry).
Major Changes:
setup.py
instead of arequirements.txt
file. Like this they get installed when thetigerrag
package gets installed. Like this the demos can run as is. The idea is that thetigerrag
package dependencies should be self contained. If I wanted to use this package I would expect it to work like all other packages (not asking me to install anotherrequirements.txt
). Might make sense to go modern and use apyproject.toml
.tigerrag
package. The current package doesn't really do anything. The demos contain the full code which seems weird. Now, the demos don't need to import any other third-party dependencies. All comes package withintigerrag
. Yay!.gitignore
file. Can't live without one to be honest. It's like a asking people to take of their shoes when entering the house. Keeps things cleanerREADME.md
files. Should be simpler to set stuff up. Demos worked (did not test langChain demo, as this one failed for me anyways)This was a "bored sunday" endeavour. Cherry-pick what you like or discard. Up to you. Good luck