Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement race-free signals using futexes #4586

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

Implement race-free signals using futexes #4586

wants to merge 2 commits into from
+250 −179

Commits on Nov 19, 2024

  1. runtime: use SA_RESTART when registering a signal 

    This really is the only sane way to register a signal. If this flag is
not set, many syscalls will return EINTR (and not complete their
operation) which will be a massive source of hard-to-debug bugs.
    @aykevl
    aykevl committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    445ca0e View commit details
    Browse the repository at this point in the history

  2. runtime: implement race-free signals using futexes 

    This requires an API introduced in MacOS 11. I think that's fine, since
the version before that (MacOS 10.15) is EOL since 2022. Though if
needed, we could certainly work around it by using an older and slightly
less nice API.
    @aykevl
    aykevl committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    bb98375 View commit details
    Browse the repository at this point in the history