Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chromium, pages/*: redirect common Chromium-based browsers as aliases, add Indonesian translations #13842

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

reinhart1010
Copy link
Collaborator

  • The page(s) are in the correct platform directories: common, linux, osx, windows, sunos, android, etc.
  • The page(s) have at most 8 examples.
  • The page description(s) have links to documentation or a homepage.
  • The page(s) follow the content guidelines.
  • The PR title conforms to the recommended templates.
  • Version of the command being documented (if known):

There is a lot of Chromium-based browsers and related commands, e.g. Google Chrome which is more known as google-chrome-stable on Linux and Microsoft Edge which is known as msedge in Windows and microsoft-edge in Linux.

I feel the best way to maintain these commands is to redirect them as alias pages.

…, add Indonesian translations

There is a lot of Chromium-based browsers and related commands, e.g. Google Chrome which is more known as `google-chrome-stable` on Linux and Microsoft Edge which is known as `msedge` in Windows and `microsoft-edge` in Linux.

I feel the best way to maintain these commands is to redirect them as alias pages.
@github-actions github-actions bot added new command Issues requesting creation of a new page. page edit Changes to an existing page(s). translation Translate pages from one language to another. labels Sep 26, 2024
@tldr-bot

This comment was marked as outdated.

@tldr-bot

This comment was marked as outdated.

@tldr-bot
Copy link

Hello! I've noticed something unusual when checking this PR:

  • The page pages.id/common/opera.md seems to be a copy of pages.id/windows/chrome.md (63% matching).
  • The page pages.id/common/vivaldi.md seems to be a copy of pages.id/windows/chrome.md (63% matching).
  • The page pages.id/linux/google-chrome-stable.md seems to be a copy of pages.id/common/google-chrome.md (87% matching).
  • The page pages.id/linux/opera-stable.md seems to be a copy of pages.id/windows/chrome.md (63% matching).
  • The page pages.id/linux/vivaldi-stable.md seems to be a copy of pages.id/windows/chrome.md (62% matching).
  • The page pages/common/opera.md seems to be a copy of pages/windows/chrome.md (65% matching).
  • The page pages/common/vivaldi.md seems to be a copy of pages/windows/chrome.md (65% matching).
  • The page pages/linux/google-chrome-stable.md seems to be a copy of pages/common/google-chrome.md (87% matching).
  • The page pages/linux/opera-stable.md seems to be a copy of pages/windows/chrome.md (65% matching).
  • The page pages/linux/vivaldi-stable.md seems to be a copy of pages/windows/chrome.md (64% matching).

Is this intended? If so, just ignore this comment. Otherwise, please double-check the commits.


`chromium --incognito {{example.com}}`
`{{chromium --incognito|microsoft-edge --inprivate}} {{example.com}}`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the command on Windows change to microsoft-edge? If so, then this should be documented in the Windows-specific page for chromium.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, so you'd recommend adding a dedicated windows/chromium page?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that way we do not show the Windows-specific stuff if you are not using TLDR on Windows (or requesting it manually).

https://github.com/tldr-pages/tldr/blob/main/contributing-guides/style-guide.md#platform-differences

@reinhart1010
Copy link
Collaborator Author

I've updated the pages. Also the start command seems unnecessary.

@tldr-bot
Copy link

Hello! I've noticed something unusual when checking this PR:

  • The page pages.id/common/opera.md seems to be a copy of pages.id/windows/chrome.md (63% matching).
  • The page pages.id/common/vivaldi.md seems to be a copy of pages.id/windows/chrome.md (63% matching).
  • The page pages.id/linux/google-chrome-stable.md seems to be a copy of pages.id/common/google-chrome.md (87% matching).
  • The page pages.id/linux/opera-stable.md seems to be a copy of pages.id/windows/chrome.md (63% matching).
  • The page pages.id/linux/vivaldi-stable.md seems to be a copy of pages.id/windows/chrome.md (62% matching).
  • The page pages/common/opera.md seems to be a copy of pages/windows/chrome.md (65% matching).
  • The page pages/common/vivaldi.md seems to be a copy of pages/windows/chrome.md (65% matching).
  • The page pages/linux/google-chrome-stable.md seems to be a copy of pages/common/google-chrome.md (87% matching).
  • The page pages/linux/opera-stable.md seems to be a copy of pages/windows/chrome.md (65% matching).
  • The page pages/linux/vivaldi-stable.md seems to be a copy of pages/windows/chrome.md (64% matching).
  • The page pages/windows/chromium.md seems to be a copy of pages/common/chromium.md (74% matching).

Is this intended? If so, just ignore this comment. Otherwise, please double-check the commits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new command Issues requesting creation of a new page. page edit Changes to an existing page(s). translation Translate pages from one language to another.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants