Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fastfetch: update no logo example #13902

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ChildishGiant
Copy link
Contributor

See fastfetch-cli/fastfetch#1058

  • The page(s) are in the correct platform directories: common, linux, osx, windows, sunos, android, etc.
  • The page(s) have at most 8 examples.
  • The page description(s) have links to documentation or a homepage.
  • The page(s) follow the content guidelines.
  • The page(s) follow the style guide.
  • The PR title conforms to the recommended templates.
  • Version of the command being documented (if known): 2.21.3 (x86_64)

@github-actions github-actions bot added the page edit Changes to an existing page(s). label Sep 29, 2024
@sebastiaanspeck sebastiaanspeck changed the title fastfetch: Update no logo example fastfetch: update no logo example Sep 30, 2024
@@ -7,10 +7,6 @@

`fastfetch`

- Display system information without a logo and escape sequences:

`fastfetch --pipe`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not change this into:
fastfetch --logo none?

I like this description better than Display no logo.

Copy link
Contributor Author

@ChildishGiant ChildishGiant Oct 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

--logo none only disables the logo, not escape sequences as that is what --pipe does now.

Copy link
Member

@sebastiaanspeck sebastiaanspeck Oct 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So --logo none does "Display system information without a logo". And if --pipe still exists, why remove it?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So --logo none does "Display system information without a logo". And if --pipe still exists, why remove it?

Went through the upstream issue, seems like the pipe flag still exists but functionality is changed and no logo printing can be achieved using --logo none. So IG here we can bring back and update the description of pipe flag example if its updated functionality is useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
page edit Changes to an existing page(s).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants