Automatic downsizing of larger-than-necessary images #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ababic
force-pushed
the
feature/resize-downloaded-images
branch
2 times, most recently
from
618b814
to
ce0701d
Compare
ababic
commented
Jul 3, 2024
ababic
force-pushed
the
feature/resize-downloaded-images
branch
12 times, most recently
from
4ed67fb
to
bf90110
Compare
ababic
force-pushed
the
feature/resize-downloaded-images
branch
4 times, most recently
from
c0a2448
to
0e04177
Compare
ababic
force-pushed
the
feature/resize-downloaded-images
branch
from
0e04177
to
c1fcee7
Compare
ababic
force-pushed
the
feature/resize-downloaded-images
branch
4 times, most recently
from
56db87d
to
f737355
Compare
ababic
force-pushed
the
feature/resize-downloaded-images
branch
from
f737355
to
43007aa
Compare
ababic
force-pushed
the
feature/resize-downloaded-images
branch
from
c5907bd
to
b1d2bd6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: Includes changes from #31, which should be reviewed/merged first
Contrary to what you might think from reviewing the documentation on the subject, setting up custom derivatives that appear in API responses alongside the default
mini,thulandwebimagevalues is quite limited, and my client couldn't find a way to reliably restrict the dimensions forWagtailSourceas we had agreed.Since Wagtail has everything we need to manipulate images on-the-fly, I thought a sensible way to avoid unreasonably large images from making it into a library (a leading cause of memory usage issues on Wagtail sites) would be to introduce the
BYNDER_SOURCE_IMAGE_MAX_WIDTHandBYNDER_SOURCE_IMAGE_MAX_HEIGHTsettings, and use them to check and downsize downloaded images before using them to set the source file.