Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a --debug option #441

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion torbrowser_launcher/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,12 @@ def main():
dest="settings",
help="Open Tor Browser Launcher settings",
)
parser.add_argument(
"--debug",
action="store_true",
default=False,
help="Launch browser in debug mode (foreground, log to terminal)",
)
parser.add_argument("url", nargs="*", help="URL to load")
args = parser.parse_args()

Expand Down Expand Up @@ -89,7 +95,7 @@ def main():
gui = Settings(common, app)
else:
# Launcher mode
gui = Launcher(common, app, url_list)
gui = Launcher(common, app, url_list, debug=args.debug)

# Center the window
desktop = app.desktop()
Expand Down
2 changes: 1 addition & 1 deletion torbrowser_launcher/common.py
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,7 @@ def build_paths(self, tbb_version=None):
"start": tbb_local
+ "/tbb/"
+ self.architecture
+ "/tor-browser/start-tor-browser.desktop",
+ "/tor-browser/Browser/start-tor-browser",
},
}

Expand Down
6 changes: 4 additions & 2 deletions torbrowser_launcher/launcher.py
Original file line number Diff line number Diff line change
Expand Up @@ -64,12 +64,13 @@ class Launcher(QtWidgets.QMainWindow):
Launcher window.
"""

def __init__(self, common, app, url_list):
def __init__(self, common, app, url_list, debug=False):
super(Launcher, self).__init__()
self.common = common
self.app = app

self.url_list = url_list
self.debug = debug
self.force_redownload = False

# This is the current version of Tor Browser, which should get updated with every release
Expand Down Expand Up @@ -478,7 +479,8 @@ def run(self):

# Run Tor Browser
subprocess.call(
[self.common.paths["tbb"]["start"]], cwd=self.common.paths["tbb"]["dir_tbb"]
[self.common.paths["tbb"]["start"], "--verbose" if self.debug else "--detach"],
cwd=self.common.paths["tbb"]["dir_tbb"],
)
sys.exit(0)

Expand Down