[trace] Add default generic parameters to ResponseBody and ResponseFuture #455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TofuWaffles
changed the title
jplatte
approved these changes
Jan 13, 2024
|
@jplatte Thank you for the review! I've added my changes to the changelog. Please let me know if there are any issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fixes issue: #233
Solution
This PR adds default generic parameters to trace::{ResponseBody, ResponseFuture}, allowing users to use these respective types while omitting several generics that can be defaulted, decreasing verbosity.
Additionally, this PR also adds two type aliases: HttpMakeClassifier and GrpcMakeClassifier, as requested in the issue mentioned.