Allow tests to read all the variable-size concrete data #310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
pgoodman
approved these changes
Sep 9, 2021
pgoodman
requested changes
Oct 5, 2022
| @@ -3,8 +3,7 @@ | |||
| * | |||
| * Licensed under the Apache License, Version 2.0 (the "License"); | |||
| * you may not use this file except in compliance with the License. | |||
| * You may obtain a copy of the License at | |||
| * | |||
| * You may obtain a copy of the Licen | |||
| @@ -259,6 +259,9 @@ extern const char *DeepState_ConcretizeCStr(const char *begin); | |||
| /* Allocate and return a pointer to `num_bytes` symbolic bytes. */ | |||
| extern void *DeepState_Malloc(size_t num_bytes); | |||
|
|
|||
| /* Allocate all the concrete inputs and return a pointer to `num_bytes` symbolic bytes. */ | |||
There was a problem hiding this comment.
Maybe rename to MallocAllConcreteInputBytes?
| void *DeepState_MallocAll(size_t *num_bytes) { | ||
| *num_bytes = DeepState_ConcreteInputIndex; | ||
| DeepState_ConcreteInputIndex = 0; | ||
| return DeepState_Malloc(*num_bytes); |
| @@ -86,6 +85,9 @@ static struct DeepState_TestInfo *DeepState_DrFuzzTest = NULL; | |||
| /* Initialize global input buffer and index / initialized index. */ | |||
| volatile uint8_t DeepState_Input[DeepState_InputSize] = {}; | |||
| uint32_t DeepState_InputIndex = 0; | |||
|
|
|||
| uint32_t DeepState_ConcreteInputIndex = 0; | |||
There was a problem hiding this comment.
Add a comment explaining what this is for.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements
DeepState_MallocAllwhich can be used to read all the concrete data available during fuzzing.