Make providers configurable, add config file for easier configuration #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arnasbr
commented
Sep 25, 2024
|
In general LGTM, although I agree that a config file would be helpful with such an amount of options. |
arnasbr
commented
Sep 26, 2024
Comment on lines
+121
to
+124
| def parse_config(file_path: str): | ||
| with open(file_path, "r") as file: # letting it crash if this fails | ||
| content = file.read() | ||
| return parse_json_to_providers(content) |
There was a problem hiding this comment.
I suppose I could add some custom error handling here, but we want to let it crash anyways, so didn't seem useful
arnasbr
changed the title
|
Added a json config file, moved provider, max_rpm and credentials configuration there |
danielnaumau
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allowing the user to easily configure which providers should be compared to TravelTime.