Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set favicon #2202

Merged
merged 1 commit into from
Sep 6, 2023
Merged

Set favicon #2202

merged 1 commit into from
Sep 6, 2023

Conversation

jeromekelleher
Copy link
Member

Should probably have a special icon for this, but lets try this out.

@codecov
Copy link

codecov bot commented Sep 6, 2023

Codecov Report

Merging #2202 (1d0aa6e) into main (8eb3184) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2202   +/-   ##
=======================================
  Coverage   91.46%   91.46%           
=======================================
  Files          20       20           
  Lines       11255    11255           
  Branches     2297     2297           
=======================================
  Hits        10294    10294           
  Misses        523      523           
  Partials      438      438           
Flag Coverage Δ
C 91.46% <ø> (ø)
python 98.68% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8eb3184...1d0aa6e. Read the comment docs.

@benjeffery
Copy link
Member

We should have one, but the logo doesn't look that great:

Screenshot from 2023-09-06 10-48-40

How about using this:
Screenshot from 2023-09-06 11-09-23

@benjeffery
Copy link
Member

I can push a commit with that if you like.

@jeromekelleher
Copy link
Member Author

That'd great, thanks!

@benjeffery
Copy link
Member

Done!

@jeromekelleher jeromekelleher merged commit 113229b into tskit-dev:main Sep 6, 2023
14 checks passed
@jeromekelleher jeromekelleher deleted the favicon branch September 6, 2023 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants