Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a sample_id column to ancestors #607

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

hyanwong
Copy link
Member

Starts to address #604. Also changes the sampledata format to 3.1. We don't actually do anything with the stored IDs yet, though!

@codecov
Copy link

codecov bot commented Nov 15, 2021

Codecov Report

Merging #607 (78d15c1) into main (69bb8c7) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #607   +/-   ##
=======================================
  Coverage   93.11%   93.11%           
=======================================
  Files          17       17           
  Lines        5155     5155           
  Branches      959      959           
=======================================
  Hits         4800     4800           
  Misses        235      235           
  Partials      120      120           
Flag Coverage Δ
C 93.11% <100.00%> (ø)
python 96.33% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
tsinfer/formats.py 98.44% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@hyanwong
Copy link
Member Author

While we in tsinfer land, do you think we could merge this too @jeromekelleher ? What's the deal with the format spec ID changes - do we make point changes or make a full integer change?

Starts to address tskit-dev#604. Also changes the sampledata format
@jeromekelleher
Copy link
Member

We don't want to invalidate all existing AncestorData files - needs to take into account this column potentially being missing and needs to test for that (== complicated).

Is there a direct downstream need for this?

@hyanwong
Copy link
Member Author

hyanwong commented Oct 5, 2022

If we are making backwards-incompatible changes, I think this is a relatively simple addition to make, and will enable matching to actual samples, which is useful e.g. for viral trees. Personally I think it worth including in https://github.com/tskit-dev/tsinfer/milestone/3 but happy to chat about it further.

@jeromekelleher
Copy link
Member

After discussion we decided to look at this after investigating the option of adding a samples argument to match_ancestors, which includes the required samples at the appropriate time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants