Fix Statement.run() for SELECT statements #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Depends on tursodatabase/libsql#1510 and tursodatabase/libsql#1511 |
Needed for Statement::run() and Connection::total_changes()
The `better-sqlite3` API allows `run()` on all types of statements. However, we currently use `libsql` crate's `Statement::execute()`, which returns an error if a statement results in rows. Fix the compatibility issue by switching to the new `Statement::run()` method in `libsql`.
penberg
force-pushed
the
fix-statement-run
branch
from
d27df77
to
2df0e5e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
better-sqlite3API allowsrun()on all types of statements. However, we currently uselibsqlcrate'sStatement::execute(), which returns an error if a statement results in rows. Fix the compatibility issue by switching to the newStatement::run()method inlibsql.