Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(combobox): modify MultiSelectComboboxProps.onSelectedItemsChange typing to reflect reality #4017

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

SethNuteTwilio
Copy link

The current typing for this prop is misleading and has caused some confusion on the Segment side of the house. From my code comment, the true behavior of the callback function here is as follows:

* If `state` prop is passed, `UseMultiSelectPrimitiveStateChange<Item>` is the type for the `newSelectedItems` callback param
*
* If `state` prop isn't passed, `any[]` is the type for the `newSelectedItems` callback param

Contributing to Twilio

All third-party contributors acknowledge that any contributions they provide will be made under the same open-source license that the open-source project is provided under.

  • I acknowledge that all my contributions will be made under the project's license.

Copy link

stackblitz bot commented Jul 31, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

changeset-bot bot commented Jul 31, 2024

🦋 Changeset detected

Latest commit: d989545

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@twilio-paste/combobox Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Jul 31, 2024

@SethNuteTwilio is attempting to deploy a commit to the Twilio Team on Vercel.

A member of the Team first needs to authorize it.

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Jul 31, 2024
Copy link

@joetessy joetessy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit d989545:

Sandbox Source
@twilio-paste/nextjs-template Configuration
@twilio-paste/token-contrast-checker Configuration

Copy link

@YiyangLi YiyangLi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@nkrantz
Copy link
Collaborator

nkrantz commented Aug 28, 2024

Hey @SethNuteTwilio, can you share a reproduction of the type error? Just want to review before we get this change in. Sorry it's taken so long to get to this, team capacity is very low right now!

@serifluous serifluous added the Contribution This is a contribution label Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Contribution This is a contribution size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants