-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(combobox): modify MultiSelectComboboxProps.onSelectedItemsChange
typing to reflect reality
#4017
base: main
Are you sure you want to change the base?
Conversation
…` typing to reflect reality
Run & review this pull request in StackBlitz Codeflow. |
🦋 Changeset detectedLatest commit: d989545 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@SethNuteTwilio is attempting to deploy a commit to the Twilio Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👀
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit d989545:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @SethNuteTwilio, can you share a reproduction of the type error? Just want to review before we get this change in. Sorry it's taken so long to get to this, team capacity is very low right now! |
The current typing for this prop is misleading and has caused some confusion on the Segment side of the house. From my code comment, the true behavior of the callback function here is as follows:
Contributing to Twilio