Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NullPointerException when paramters key in URI contains semicolon #124

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

clvs7-gh
Copy link

Issue

When a semicolon is used in parameter key of the URI provided by the QR code, a NullPointerException occurs in the mapQueryParams function, resulting in the message This QR Code does not work! being displayed and the QR code unable to be loaded. This fix addresses the issue.

Effects of this fix

With this fix, services that generate URIs contains semicolon (;), such as SimpleLogin with ...&issuer=... in the URI, will also be registerable. (Such URI can be loaded in other apps like Microsoft Authenticator and Authy as well.)

You can verify the fix using the following QR code generator:

https://stefansundin.github.io/2fa-qr/

Test URIs:

  • otpauth://totp/SAMPLE?secret=SAMPLE123&issuer=Example
    • Contains a semicolon in the parameter name; similar to output from SimpleLogin (maybe their's bug)

Previous behavior before the fix

Displays "This QR Code does not work!" and cannot be registered.

Behavior after the fix

Registration is possible without displaying an error, similar to other apps.

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant