Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tidy up the output during installation #28

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Tidy up the output during installation #28

wants to merge 3 commits into from

Commits on Jul 28, 2022

  1. 🎨 Tidy up wget and gpg output during installation

    @canterberry
    canterberry committed Jul 28, 2022
    Configuration menu
    Copy the full SHA
    e55e491 View commit details
    Browse the repository at this point in the history

  2. 🎨 Ignore GPG output on signature verification 

    This plugin uses a dedicated keyring containing only the signing key
we know to trust because we obtained it from an official source via
a secure channel. However, because we haven't told GPG that we trust
the key, we see a trust warning when attempting to verify a signature
made using that key. This warning is spurious (aside: the GPG-level
trust model is esoteric and rarely used, in favor of pushing trust
upward to ensure you're only using trusted keys to verify signatures
in the first place).

If signature verification fails, we'll still get a non-zero exit code,
which will halt the process from continuing to install the errant file.
    @canterberry
    canterberry committed Jul 28, 2022
    Configuration menu
    Copy the full SHA
    4e122b3 View commit details
    Browse the repository at this point in the history

  3. 🎨 Prettifying progress updates 

    Writing progress to standard error (vs standard output)
because it is intended for humans to read (vs machines).
    @canterberry
    canterberry committed Jul 28, 2022
    Configuration menu
    Copy the full SHA
    5ff06a5 View commit details
    Browse the repository at this point in the history