Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sidecars support #101

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Add sidecars support #101

wants to merge 3 commits into from

Conversation

fgiannetti
Copy link

Add the ability to specify sidecar containers.
The motivation on this change is because I need to implement a whitelist for the registry (in proxy mode) and as the registry image does not support a whitelist configuration, the alternative is running a reverse proxy in the pod to reject the non-whitelisted images
The reverse proxy could run in other pod, however, allowing sidecars to be set will help whoever needs it.
Hope it helps!

@0xDEC0DE
Copy link

0xDEC0DE commented May 1, 2023

This looks promising. A terrific use case for this would be running docker_auth as a sidecar, instead of as a separate pod.

Do you think you could update the docs with instructions on getting that working?

@fgiannetti
Copy link
Author

This looks promising. A terrific use case for this would be running docker_auth as a sidecar, instead of as a separate pod.

Do you think you could update the docs with instructions on getting that working?

I modified the Readme file to include this field, but the sidecar container configuration is unique to each one. That configuration should be included using this new 'sidecars' feature ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants