Skip to content

Commit

Permalink
AOSP: Use no_full_install: true instead of installable: false
Browse files Browse the repository at this point in the history
So far, we have used `instalable: false` to avoid collision with the
other modules that are installed to the same path. A typical example was
<foo> and <foo>.microdroid. The latter is a modified version of the
former for the inclusion of the microdroid image. They however both have
the same instalation path (ex: system/bin) and stem (ex: foo) so that we
can reference them using the same path regardless of whether we are in
Android or microdroid.

However, the use of `installable: false` for the purpose is actually
incorrect, because `installable: false` also means, obviously, "this
module shouldn't be installed". The only reason this incorrect way has
worked is simply because packaging modules (ex: android_filesystem)
didn't respect the property when gathering the modules.

As packaging modules are now fixed to respect `installable: false`, we
need a correct way of avoiding the collision. `no_full_install: true` is
it.

If a module has this property set to true, it is never installed to the
full instal path like out/target/product/<partition>/... It can be
installed only via packaging modules.

Bug: 338160898
Test: m
Change-Id: Idb173a7e3528c96b23f857bb3bdf5f37e698c445
From AOSP commit: 21a895548df7de83ce1e2e146e1718e5f723af7f
  • Loading branch information
jiyongp authored and tytso committed May 20, 2024
1 parent eb5788f commit 0cdf513
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion misc/Android.bp
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ cc_binary {
symlinks: ["mkfs.ext4.microdroid"],
},
},
installable: false,
no_full_install: true,
stem: "mke2fs",
visibility: ["//packages/modules/Virtualization/microdroid"],
}
Expand Down

0 comments on commit 0cdf513

Please sign in to comment.