Solve communication problems with jupiter #308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PMPY could not find the full path to jupiter because it was using the URI request_uri which is the path after the localhost. If PMPY and jupiter are on different servers, this will not work.
lagoan
requested review from
ConnorSheremeta,
henryzhang87,
pgwillia and
piyapongch
as code owners
ConnorSheremeta
previously approved these changes
Mar 16, 2023
lib/pushmi_pullyu/aip/downloader.rb
Outdated
| @@ -86,7 +86,7 @@ def authenticate_http_calls | |||
| @uri = URI.parse(PushmiPullyu.options[:jupiter][:jupiter_url]) | |||
| @http = Net::HTTP.new(@uri.host, @uri.port) | |||
| @http.use_ssl = true if @uri.instance_of? URI::HTTPS | |||
| request = Net::HTTP::Post.new("#{@uri.request_uri}auth/system") | |||
| request = Net::HTTP::Post.new(URI.join(@uri,'/auth/system')) | |||
There was a problem hiding this comment.
LGTM except this robocop violation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Please describe any relevant motivation and context for these changes.
PMPY was not working in staging and all preservation attempts failed. PMPY could not find the full path to jupiter because it was using the URI request_uri which is the path after the localhost. If PMPY and jupiter are on different servers, this will not work.
Related to #297
What's New
Changed use of method URI.request_uri to joining URI with new path.