-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add JNI config for native image #153
Conversation
/cc @isaacbrodsky |
/cc @dfellis |
Going to add the include resources as well, as we need to include the native libs, just a sec... |
Added resource configuration as well, now it loads the lib correclty =) |
Pull Request Test Coverage Report for Build #435Details
💛 - Coveralls |
Native image needs the jni config and the resource config, as it needs to load the lib and without the resource config it wouldn't find the native lib. Thanks @isaacbrodsky @dfellis for the prompt reviews =) |
@dfellis @isaacbrodsky can you trigger the test again please? it failed pulling a docker image |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be nice if we could test that this json definition is correct, perhaps by running GraalVM or something that consumes it in CI?
@isaacbrodsky I will open a PR with native image tests, and hopefully you can do a release after validating that native and everything is working? (found out that we need to tweak the resources file) |
Adds JNI config for native image, with that we are able to use the lib and compile to native image with GraalVM.
The
META-INF
native-image
folder/files follows the docs. All the classes accessed through JNI needs to be there, and methods as well, all existing methods are supported in native image with this newjni-config.json
file added.Fixes #55