Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: contentTabs order support #2056

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

LesterWeng
Copy link

🤔 这个变动的性质是?/ What is the nature of this change?

  • 新特性提交 / New feature
  • bug 修复 / Fix bug
  • 样式优化 / Style optimization
  • 代码风格优化 / Code style optimization
  • 性能优化 / Performance optimization
  • 构建优化 / Build optimization
  • 网站、文档、Demo 改进 / Website, documentation, demo improvements
  • 重构代码或样式 / Refactor code or style
  • 测试相关 / Test related
  • 其他 / Other

🔗 相关 Issue / Related Issue

💡 需求背景和解决方案 / Background or solution

contentTabs目前支持自定义排序

📝 更新日志 / Changelog

Language Changelog
🇺🇸 English
🇨🇳 Chinese

Copy link

vercel bot commented Mar 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
dumi ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 25, 2024 9:46am

</li>
))}
{tabs!
.sort(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

顺序设置后是不会变的,每次渲染都重新排序会比较浪费,在 tabs 数据生成的时候做排序更合适:

  1. routeMeta.tabs = tabs.map((tabId) =>
    genTab(tabId, getRouteMetaById(tabId, opts)),
    );
  2. routeMeta.tabs = await Promise.all(
    tabs.map(async (tabId) =>
    genTab(tabId, await getRouteMetaById(tabId, opts)),
    ),
    );

另外文档里也加一下 order 的用法示例吧:https://d.umijs.org/guide/page-tab

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants