fix(qiankun): should remove internal cache of loadMicroApp while load…

…ing failed (#2922)
umijs · Mar 6, 2024 · e28c729 · e28c729
1 parent 9c56910
commit e28c729
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 1 deletion.
diff --git a/.changeset/poor-squids-hide.md b/.changeset/poor-squids-hide.md
@@ -0,0 +1,5 @@
+---
+"qiankun": patch
+---
+
+fix(qiankun): should remove internal cache of loadMicroApp while loading failed
diff --git a/packages/qiankun/src/apis/loadMicroApp.ts b/packages/qiankun/src/apis/loadMicroApp.ts
@@ -71,12 +71,21 @@ export function loadMicroApp<T extends ObjectType>(
 
     const parcelConfigObjectGetterPromise = loadApp(app, userConfiguration, lifeCycles);
 
+    let parcelConfigObjectGetter: ParcelConfigObjectGetter | undefined;
+
     if (containerXPath) {
       const appContainerXPathKey = getContainerXPathKey(containerXPath);
       appConfigPromiseGetterMap.set(appContainerXPathKey, parcelConfigObjectGetterPromise);
+      try {
+        parcelConfigObjectGetter = await parcelConfigObjectGetterPromise;
+      } catch (e) {
+        appConfigPromiseGetterMap.delete(appContainerXPathKey);
+        throw e;
+      }
     }
 
-    return (await parcelConfigObjectGetterPromise)(container);
+    parcelConfigObjectGetter = parcelConfigObjectGetter || (await parcelConfigObjectGetterPromise);
+    return parcelConfigObjectGetter(container);
   };
 
   if (!started) {