-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: icons插件增加ant-design/icons类型提示 #11891
base: master
Are you sure you want to change the base?
feat: icons插件增加ant-design/icons类型提示 #11891
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #11891 +/- ##
==========================================
- Coverage 28.89% 28.81% -0.09%
==========================================
Files 488 488
Lines 14892 14935 +43
Branches 3538 3545 +7
==========================================
Hits 4303 4303
- Misses 9829 9869 +40
- Partials 760 763 +3 ☔ View full report in Codecov by Sentry. |
我实际看了一下,用户不一定需要 ant design icons 这个依赖他就能用 antd icons ,因为 iconify 把所有 svg 给抽取变成 json 了,所以代码逻辑我做了一些调整。 因为 antd icons 已经很多了,类型字符串很大,特别是如果还用了 mdi ,那更加庞大,在我的电脑(比较旧)上如果不人为按下类型提示按钮甚至都不会有类型提示自动出现,另外我感觉 |
我认为这个 PR 可以提升一部分体验,但生成的类型真的很大,实际上可能会造成较大的 IDE 加载类型时带来的性能压力(如风扇一直转)。 |
No description provided.