Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use makefile nightly in diplomat-coverage #5286

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sffc
Copy link
Member

@sffc sffc commented Jul 23, 2024

Follow-up to #5283

@sffc sffc requested review from Manishearth and a team as code owners July 23, 2024 23:51
@sffc sffc requested review from robertbastian and removed request for a team and Manishearth July 23, 2024 23:51
@sffc
Copy link
Member Author

sffc commented Jul 23, 2024

This works locally; why doesn't it work on CI?

error: environment variable `ICU4X_DIPLOMAT_COVERAGE_NIGHTLY` not defined at compile time
   --> tools/make/diplomat-coverage/src/main.rs:102:35
    |
102 |                 .args(["install", std::env!("ICU4X_DIPLOMAT_COVERAGE_NIGHTLY")])
    |                                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: use `std::env::var("ICU4X_DIPLOMAT_COVERAGE_NIGHTLY")` to read the variable at run time
    = note: this error originates in the macro `std::env` (in Nightly builds, run with -Z macro-backtrace for more info)

error: environment variable `ICU4X_DIPLOMAT_COVERAGE_NIGHTLY` not defined at compile time
   --> tools/make/diplomat-coverage/src/main.rs:108:21
    |
108 |                     std::env!("ICU4X_DIPLOMAT_COVERAGE_NIGHTLY"),
    |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: use `std::env::var("ICU4X_DIPLOMAT_COVERAGE_NIGHTLY")` to read the variable at run time
    = note: this error originates in the macro `std::env` (in Nightly builds, run with -Z macro-backtrace for more info)

@robertbastian
Copy link
Member

I don't know why it doesn't work in CI, but even locally this shouldn't work, because the rustdoc-types dependency is tightly coupled to nightly ranges.

Copy link
Member

@robertbastian robertbastian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

@sffc
Copy link
Member Author

sffc commented Jul 25, 2024

The CI failure is before it gets around to rustdoc-types.

Should we leave this one alone and close the PR?

@Manishearth
Copy link
Member

We should try to update to a newer (but pinned) nightly here if possible but I don't think it's super important

@robertbastian robertbastian marked this pull request as draft August 7, 2024 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants