WIP preferences #5573
Draft
WIP preferences #5573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertbastian
requested review from
sffc,
Manishearth,
hsivonen,
echeran and
a team
as code owners
robertbastian
removed request for
a team,
hsivonen,
echeran,
sffc and
Manishearth
sffc
reviewed
Sep 23, 2024
Comment on lines
+191
to
+200
| impl ResolvedFixedDecimalFormatterPreferences { | ||
| fn as_data_id(&self) -> DataIdentifierBorrowed { | ||
| DataIdentifierBorrowed::for_marker_attributes_and_locale( | ||
| DataMarkerAttributes::from_str_or_panic( | ||
| self.numbering_system.0.as_str() | ||
| ), | ||
| &self.data_locale, | ||
| ) | ||
| } | ||
| } |
There was a problem hiding this comment.
Praise: I like the pattern of pre-computing the DataLocale and putting this code into an associated function.
| #[allow(clippy::unwrap_used)] // temporary | ||
| ResolvedFixedDecimalFormatterPreferences { | ||
| data_locale: DataLocale::from(self.lid), | ||
| numbering_system: self.numbering_system.unwrap(), |
There was a problem hiding this comment.
Issue: it should just be stored as an Option, I think? We don't actually have a way to retrieve the resolved numbering system from data because that wasn't a design constraint until now. Maybe we should add it to DecimalSymbolsV2, #4437
| fn from(loc: icu_locale_core::Locale) -> Self { | ||
|
|
||
| let lid = Some(loc.id); | ||
| impl<'a> From<&'a $crate::preferences::icu_locale_core::Locale> for $name<'a> { |
There was a problem hiding this comment.
Discussion: Do we want an impl from both Locale and &Locale?
There was a problem hiding this comment.
Please post discussions in the issue
| impl<'a> From<&'a ResolvedCollatorPreferences> for DataIdentifierCow<'a> { | ||
| fn from(value: &'a ResolvedCollatorPreferences) -> Self { | ||
| Self::from_borrowed_and_owned( | ||
| match value.collation_type { |
There was a problem hiding this comment.
Question: should this match live here or in icu_preferences code?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.