Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ZeroAsciiIgnoreCaseTrie::get_strict #5585

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

Add ZeroAsciiIgnoreCaseTrie::get_strict #5585

wants to merge 5 commits into from

Conversation

sffc
Copy link
Member

@sffc sffc commented Sep 24, 2024

@sffc sffc requested a review from a team as a code owner September 24, 2024 01:07
@sffc sffc mentioned this pull request Sep 24, 2024
Merged
robertbastian
robertbastian previously approved these changes Sep 24, 2024
View reviewed changes
utils/zerotrie/src/options.rs Outdated Show resolved Hide resolved
Manishearth
Manishearth previously approved these changes Sep 24, 2024
View reviewed changes
@sffc sffc dismissed stale reviews from Manishearth and robertbastian via 460fef0 September 25, 2024 20:41
Manishearth
Manishearth previously approved these changes Sep 25, 2024
View reviewed changes
@sffc sffc marked this pull request as draft September 30, 2024 16:37
@sffc
Copy link
Member Author

sffc commented Sep 30, 2024

I want to see if I can finish #5615 and if it is performant, it will be a better solution than the one in this PR. If #5615 doesn't work out, I'll re-open this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Manishearth Manishearth Manishearth approved these changes

@robertbastian robertbastian robertbastian left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sffc @Manishearth @robertbastian