-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove FlexZeroVec #5604
Remove FlexZeroVec #5604
Conversation
913eb00
to
483d741
Compare
@sffc one lingering use case is in the ZeroTrie benches: icu4x/utils/zerotrie/benches/overview.rs Line 101 in 7634c7e
This is the I don't really think it makes sense for usize to special-case as a flex container anyway. |
The other breakage is in BlobSchemaV1, which is probably going to go away in #5603 icu4x/provider/blob/src/blob_schema.rs Line 80 in 7634c7e
|
483d741
to
775f83c
Compare
f9888f8
to
775f83c
Compare
This can't be landed until we fix #5603 |
dc3669f
to
1265158
Compare
The bulk of the FZV usage is in the ZeroTrie benches 🙃 |
e3b2cdc
to
81f3f21
Compare
utils/zerotrie/benches/overview.rs
Outdated
@@ -57,11 +57,11 @@ fn get_basic_bench(c: &mut Criterion) { | |||
|
|||
#[cfg(feature = "bench")] | |||
g.bench_function("ZeroMap/usize", |b| { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
g.bench_function("ZeroMap/usize", |b| { | |
g.bench_function("ZeroMap/u32", |b| { |
utils/zerotrie/benches/overview.rs
Outdated
@@ -171,11 +155,11 @@ fn get_subtags_bench_helper<M: criterion::measurement::Measurement>( | |||
|
|||
#[cfg(feature = "bench")] | |||
g.bench_function("ZeroMap/usize", |b| { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
g.bench_function("ZeroMap/usize", |b| { | |
g.bench_function("ZeroMap/u32", |b| { |
9c5f32f
to
c759ff2
Compare
What changed across the force-push? I see a bunch of changes pulled in from main. |
@sffc rebase over main and fix the zerotrie builder test numbers broken by the VZV changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the two diffs you applied earlier got undone
Oops, fixed. Forgot I applied those patches late at night |
We don't really use it anymore I think, except potentially for some
usize
ZHMs, which we can instead use Index8 VZV backing stores for if we desire.