Remove Blob schema v1, v2, add v3 #5608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Manishearth
requested review from
zbraniecki,
nordzilla and
a team
as code owners
Manishearth
force-pushed
the
blob-rm
branch
3 times, most recently
from
a945bab
to
36c1343
Compare
Manishearth
force-pushed
the
blob-rm
branch
from
36c1343
to
9832712
Compare
Manishearth
force-pushed
the
blob-rm
branch
from
9832712
to
e0e608c
Compare
robertbastian
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5603
v3 isn't yet necessary but will become necessary with #5601. This can be landed independently of #5601 but these PRs will bitrot each other. Slight preference to landing this first.
(At the moment, V2 == V3, but #5601 breaks the format)
This makes V1 and V2 data still detectable by ICU4X, but they will throw a helpful error when attempting to load them.
From a user's POV, there is now only the "blob" format (which covers both V003 and V003Bigger, picked at datagen time based on data size.