Consistently use bytes not byte_slice
#5816
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Manishearth
requested review from
sffc,
zbraniecki,
nciric,
younies,
echeran and
a team
as code owners
Manishearth
force-pushed
the
bytes-not-byte-slice
branch
from
c161875
to
afc957d
Compare
|
Reviewer note: can be reviewed individually. Do take a look at non-zerovec code affected by each commit in case something incorrect snuck through. |
Manishearth
force-pushed
the
bytes-not-byte-slice
branch
2 times, most recently
from
e8a2cf4
to
ea2c68a
Compare
Manishearth
force-pushed
the
bytes-not-byte-slice
branch
from
9495904
to
8a22eff
Compare
sffc
previously approved these changes
Nov 15, 2024
| @@ -367,7 +367,7 @@ impl CaseMapDataULE { | |||
| /// 6. The equality invariant is satisfied | |||
| unsafe impl ULE for CaseMapDataULE { | |||
| fn validate_byte_slice(bytes: &[u8]) -> Result<(), UleError> { | |||
| let sixteens = RawBytesULE::<2>::parse_byte_slice(bytes)?; | |||
| let sixteens = RawBytesULE::<2>::parse_bytes(bytes)?; | |||
There was a problem hiding this comment.
I like this being parse() but it's worth discussing. I'd want to do that separately IMO.
| @@ -97,7 +97,7 @@ impl<'a, V: VarULE + ?Sized> VarZeroCow<'a, V> { | |||
| } | |||
|
|
|||
| /// Construct from an owned slice. Errors if the slice doesn't represent a valid `V` | |||
| pub fn parse_owned_byte_slice(bytes: Box<[u8]>) -> Result<Self, UleError> { | |||
| pub fn parse_owned_bytes(bytes: Box<[u8]>) -> Result<Self, UleError> { | |||
There was a problem hiding this comment.
Suggestion (optional): try_from_boxed_bytes or parse_boxed_bytes. I think "boxed bytes" is language used elsewhere
There was a problem hiding this comment.
I think for a Cow type "owned" is probably better.
Manishearth
force-pushed
the
bytes-not-byte-slice
branch
from
1e698de
to
790b235
Compare
sffc
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5815