Register string datatype and update existing tests #1766
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## ibis-dev #1766 +/- ##
============================================
- Coverage 94.29% 92.78% -1.51%
============================================
Files 91 130 +39
Lines 7024 9454 +2430
============================================
+ Hits 6623 8772 +2149
- Misses 401 682 +281 ☔ View full report in Codecov by Sentry. |
|
hey @deepyaman is this meant to be merged into the |
Yes, of course! |
deepyaman
force-pushed
the
feat/ibis/string-dtype
branch
from
bf70457
to
55cf0f9
Compare
Signed-off-by: Deepyaman Datta <[email protected]>
deepyaman
force-pushed
the
feat/ibis/string-dtype
branch
from
55cf0f9
to
b28bd97
Compare
cosmicBboy
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add string datatype support (and uncomment related tests).
Built on top of #1762; please review that first! 🙏