Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not test Ibis below py3.9, add DuckDB for tests #1773

Merged
merged 4 commits into from
Aug 15, 2024
Merged

Do not test Ibis below py3.9, add DuckDB for tests #1773

merged 4 commits into from
Aug 15, 2024

Conversation

deepyaman
Copy link
Collaborator

@deepyaman deepyaman commented Aug 1, 2024 •
edited
Loading

Ibis follows NEP-29 much more aggressively than Pandera, so not going to bother with anything older than Python 3.10 but still trying to run with 3.10 (for now). Hopefully this will make some of the CI issues go away.

See also: #1451 (comment)

@codecov Codecov
Copy link

codecov bot commented Aug 1, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.84%. Comparing base (4df61da) to head (89fd955).
Report is 143 commits behind head on ibis-dev.

Additional details and impacted files 
@@             Coverage Diff              @@
##           ibis-dev    #1773      +/-   ##
============================================
- Coverage     94.29%   92.84%   -1.45%     
============================================
  Files            91      130      +39     
  Lines          7024     9403    +2379     
============================================
+ Hits           6623     8730    +2107     
- Misses          401      673     +272

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@deepyaman
Copy link
Collaborator Author

keys_sorted is only exposed in PyArrow 13; see apache/arrow@1deb740

@deepyaman deepyaman force-pushed the ci/ibis-test-reqs branch 3 times, most recently from 74c46f1 to ea391fc Compare August 1, 2024 06:10
@deepyaman deepyaman marked this pull request as draft August 1, 2024 12:00
@deepyaman deepyaman changed the title Don't test Ibis below py3.10, add DuckDB for tests Do not test Ibis below py3.9, add DuckDB for tests Aug 1, 2024
@deepyaman
Copy link
Collaborator Author

deepyaman commented Aug 1, 2024 •
edited
Loading

@cosmicBboy I would prefer to drop 3.8 and 3.9 altogether; see https://discord.com/channels/897120336003334214/1237117799810469928/1268547405046087750 for a lot more details.

edit: 3.8 and 3.9, not 3.9 and 3.10

@deepyaman deepyaman marked this pull request as ready for review August 8, 2024 17:32
@deepyaman
Copy link
Collaborator Author

Failing now because need #1779; I can cherry-pick it in once merged to main.

@deepyaman
Swap types-pkg_resources with types-setuptools (unionai-oss#1779)
f6317d6 
* Swap `types-pkg_resources` with `types-setuptools`

Signed-off-by: Deepyaman Datta <[email protected]>

* Update the expected error message to name variable

Signed-off-by: Deepyaman Datta <[email protected]>

* Fix expected outputs for pandas-stubs 2.2.2.240807

Signed-off-by: Deepyaman Datta <[email protected]>

* Update CI configuration to filter right pandas ver

Signed-off-by: Deepyaman Datta <[email protected]>

---------

Signed-off-by: Deepyaman Datta <[email protected]>
@cosmicBboy
Copy link
Collaborator

just merged #1779, thanks for the fix!

@deepyaman
Copy link
Collaborator Author

just merged #1779, thanks for the fix!

Thanks @cosmicBboy! I updated this PR, also merging the changes from main, so that ibis-dev can have the fix.

@cosmicBboy cosmicBboy merged commit 1107ab4 into unionai-oss:ibis-dev Aug 15, 2024
154 of 155 checks passed
@deepyaman deepyaman deleted the ci/ibis-test-reqs branch August 15, 2024 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cosmicBboy cosmicBboy cosmicBboy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@deepyaman @cosmicBboy