feat: `CommandBarFlyout` #10411

MartinZikmund · 2022-11-11T22:17:56Z

GitHub Issue (If applicable): closes #12165

PR Type

What kind of change does this PR introduce?

Feature

What is the current behavior?

Not supported

What is the new behavior?

Supported

TODO

Workaround missing SystemBackdrop support

PR Checklist

Please check if your PR fulfills the following requirements:

Docs have been added/updated which fit documentation template (for bug fixes / features)
Unit Tests and/or UI Tests for the changes have been added (for bug fixes / features) (if applicable)
Validated PR Screenshots Compare Test Run results.
Contains NO breaking changes
Associated with an issue (GitHub or internal) and uses the automatic close keywords.
Commits must be following the Conventional Commits specification.

gitpod-io · 2022-11-11T22:18:05Z

...UI/Microsoft/UI/Xaml/Controls/CommandBarFlyout/CommandBarFlyoutCommandBarTemplateSettings.cs

src/Uno.UI/Microsoft/UI/Xaml/Controls/CommandBarFlyout/CommandBarFlyoutCommandBar.mux.cs

jeromelaban

Looking good, though still quite a few build failures :)

jeromelaban · 2022-11-24T14:50:33Z

src/Uno.UI/Microsoft/UI/Xaml/Controls/CommandBarFlyout/CommandBarFlyout.mux.cs

+	// TODO:MZ: Move to Unloaded
+	//CommandBarFlyout.~public CommandBarFlyout()
+	//{
+	//	m_primaryCommands.VectorChanged(m_primaryCommandsVectorChangedToken);
+	//	m_secondaryCommands.VectorChanged(m_secondaryCommandsVectorChangedToken);
+
+	//	UnhookAllCommandBarElementDependencyPropertyChanges();
+	//}


Was it moved?

unodevops · 2024-03-31T20:42:18Z

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-10411/index.html

unodevops · 2024-03-31T21:20:45Z

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-10411/index.html

unodevops · 2024-04-15T11:54:36Z

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-10411/index.html

unodevops · 2024-04-15T12:29:20Z

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-10411/index.html

unodevops · 2024-04-15T13:45:57Z

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-10411/index.html

unodevops · 2024-04-15T17:45:16Z

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-10411/index.html

unodevops · 2024-10-29T16:14:42Z

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-10411/index.html

MartinZikmund self-assigned this Nov 11, 2022

Youssef1313 reviewed Nov 12, 2022

View reviewed changes

...UI/Microsoft/UI/Xaml/Controls/CommandBarFlyout/CommandBarFlyoutCommandBarTemplateSettings.cs Outdated Show resolved Hide resolved

MartinZikmund force-pushed the dev/mazi/winui-commandbarflyout branch 3 times, most recently from 3a35ada to 86d1e73 Compare November 16, 2022 09:21

github-actions bot added the area/automation Categorizes an issue or PR as relevant to project automation label Nov 17, 2022

MartinZikmund changed the title ~~[WIP] feat: CommandBarFlyout~~ feat: CommandBarFlyout Nov 17, 2022

MartinZikmund marked this pull request as ready for review November 17, 2022 13:52

MartinZikmund force-pushed the dev/mazi/winui-commandbarflyout branch 2 times, most recently from dda14f8 to 0dcbb8d Compare November 17, 2022 14:23

Youssef1313 reviewed Nov 18, 2022

View reviewed changes

src/Uno.UI/Microsoft/UI/Xaml/Controls/CommandBarFlyout/CommandBarFlyoutCommandBar.mux.cs Outdated Show resolved Hide resolved

Youssef1313 reviewed Nov 18, 2022

View reviewed changes

src/Uno.UI/Microsoft/UI/Xaml/Controls/CommandBarFlyout/CommandBarFlyoutCommandBar.mux.cs Outdated Show resolved Hide resolved

jeromelaban reviewed Nov 24, 2022

View reviewed changes

MartinZikmund force-pushed the dev/mazi/winui-commandbarflyout branch from c3d8cab to 3b09d9f Compare December 15, 2022 08:39

MartinZikmund enabled auto-merge December 15, 2022 12:14

jeromelaban marked this pull request as draft January 16, 2023 18:34

auto-merge was automatically disabled January 16, 2023 18:34
Pull request was converted to draft

MartinZikmund force-pushed the dev/mazi/winui-commandbarflyout branch 2 times, most recently from 322fcd8 to 1144b9c Compare May 10, 2023 08:24

MartinZikmund mentioned this pull request Nov 7, 2023

Update Controls to WinUI 3 sources #14275

Open

MartinZikmund force-pushed the dev/mazi/winui-commandbarflyout branch from 1144b9c to f3c0e82 Compare March 31, 2024 20:14

MartinZikmund force-pushed the dev/mazi/winui-commandbarflyout branch from bcd56f5 to f79633b Compare April 15, 2024 11:30

MartinZikmund force-pushed the dev/mazi/winui-commandbarflyout branch from 233cf11 to 038c701 Compare April 15, 2024 15:25

MartinZikmund added 29 commits October 29, 2024 16:38

chore: TextCommandBarFlyout header ported, command porting

0b05501

feat: TextCommandBarFlyout

57771af

chore: Continued command porting

6e11d27

chore: Finalized porting

63dcf35

test: CommandBarFlyout runtime tests

0f4fb44

test: CommandBarFlyout samples

d53d2f3

chore: CommandBarFlyout styles

53973fb

chore: Add missing extensions file

7834947

chore: Adjust for RichEditBox

a9f4c24

chore: Avoid WUX control, initialize revokers

ad56c8a

chore: Address comment

5995a7d

chore: Updating to WinUI tree started

dd65101

chore: Further updates

1f2c44c

chore: Update sample pages to latest WinUI sources

8dd92ed

chore: Update control's XAML to latest

602a168

test: API tests

9bd338f

chore: Update CBF header

6c478eb

chore: Update CommandBarFlyout.mux.cs to latest

2fe0ff6

chore: Update CommandBarFlyoutCommandBar.h.mux.cs

cb2b7d9

chore: Update CommandBarFlyoutCommandBar.cpp to latest

e101ec3

chore: Update TextCommandBarFlyout to latest WinUI sources

709f0e8

chore: Update references

a13fd39

chore: Clean up unsupported code for SystemBackdrop

175c185

chore: Additional adjustments

0c4ec63

chore: UWP build adjustments

1199cd5

chore: Add stub backdrop types

145fba0

feat: Update AcrylicBrush resources

620eae5

chore: Keep MUX namespace

5aaa9ec

chore: Change brush for acrylic backdrop

68b4a14

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: `CommandBarFlyout` #10411

feat: `CommandBarFlyout` #10411

MartinZikmund commented Nov 11, 2022 •

edited

Loading

gitpod-io bot commented Nov 11, 2022

jeromelaban left a comment

jeromelaban Nov 24, 2022

unodevops commented Mar 31, 2024

unodevops commented Mar 31, 2024

unodevops commented Apr 15, 2024

unodevops commented Apr 15, 2024

unodevops commented Apr 15, 2024

unodevops commented Apr 15, 2024

unodevops commented Oct 29, 2024

feat: CommandBarFlyout #10411

Are you sure you want to change the base?

feat: CommandBarFlyout #10411

Conversation

MartinZikmund commented Nov 11, 2022 • edited Loading

PR Type

What is the current behavior?

What is the new behavior?

TODO

PR Checklist

gitpod-io bot commented Nov 11, 2022

jeromelaban left a comment

Choose a reason for hiding this comment

jeromelaban Nov 24, 2022

Choose a reason for hiding this comment

unodevops commented Mar 31, 2024

unodevops commented Mar 31, 2024

unodevops commented Apr 15, 2024

unodevops commented Apr 15, 2024

unodevops commented Apr 15, 2024

unodevops commented Apr 15, 2024

unodevops commented Oct 29, 2024

feat: `CommandBarFlyout` #10411

feat: `CommandBarFlyout` #10411

MartinZikmund commented Nov 11, 2022 •

edited

Loading