fix(wasm): key tracking when no one is subscribing to Key<Down|Up> #18702
+36
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This affects NavigationView (as reported in the original issue) because, for some reason, NavigationView's logic is written so that if any modifiers are pressed, it should not open the picker popup. |
ramezgerges
force-pushed
the
wasm_modifier_key_tracking
branch
from
f2f751b
to
542a226
Compare
jeromelaban
reviewed
Nov 5, 2024
| #if __WASM__ | ||
| #pragma warning disable IDE0051 // Remove unused private members | ||
| [JSExport] | ||
| private static void UpdateKeyStateNative(string key, bool down) |
There was a problem hiding this comment.
Can you add a manual test that explains what to test? Thanks!
|
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-18702/index.html |
|
🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-18702/index.html |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Issue (If applicable): closes #18617
PR Type
What kind of change does this PR introduce?
What is the current behavior?
What is the new behavior?
PR Checklist
Please check if your PR fulfills the following requirements:
Screenshots Compare Test Runresults.Other information
Internal Issue (If applicable):